Skip to content

fix(repository): remove deprecated has_downloads property - #4138

Closed
danilpashin wants to merge 1 commit into
google:masterfrom
danilpashin:branch1
Closed

danilpashin wants to merge 1 commit into
google:masterfrom
danilpashin:branch1

Conversation

@danilpashin

Copy link
Copy Markdown

What changed?

  • Removed deprecated HasDownloads property from all repository payload structures
  • Deleted corresponding field from Repository struct and related accessors

Why?

  • GitHub API version 2026-03-10 no longer returns this field
  • Property has been deprecated and is safe to remove

Testing

  • All tests pass locally: go test ./...
  • Coverage: 93.3% (unchanged from master)

@google-cla

google-cla Bot commented Apr 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexandear alexandear left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the property. The library is for GitHub API "2022-11-28"

defaultAPIVersion = "2022-11-28"

@danilpashin

Copy link
Copy Markdown
Author

We can't remove the property. The library is for GitHub API "2022-11-28"

Thanks for the explanation! I didn't realize the library needed to support older API versions. I understand why this field can't be removed. I'll close this PR stunt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants