This repository was archived by the owner on Jul 29, 2026. It is now read-only.
Repository navigation
Display months instead of days issue #332 - #336
Merged
Merged
Conversation
samtstern
reviewed
Feb 8, 2022
| const withColons = `:${k}:`; | ||
| const asEmoji = emojis[k]; | ||
| content = content.replace(new RegExp(withColons, "g"), asEmoji); | ||
| const contentList = content.split("```"); |
Contributor
There was a problem hiding this comment.
@jollypolly123 could you remove these changes from this PR so that it's just the date part?
Contributor
Author
There was a problem hiding this comment.
Just changed! Sorry if this isn't proper etiquette, but is that change being reviewed? It's in PR #335
samtstern
reviewed
Feb 8, 2022
| return "today"; | ||
| } else if (daysAgo === 1) { | ||
| return "yesterday"; | ||
| } else if (daysAgo > 30) { |
samtstern
suggested changes
Feb 8, 2022
samtstern
left a comment
samtstern
left a comment
Contributor
There was a problem hiding this comment.
I'll approve this PR once we remove the emoji changes from this.
samtstern
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.