Repository navigation
test(console): make test_pty_console_full deterministic - #549
Merged
Merged
Conversation
On Linux, a kworker moves the output written to a PTY master into the line discipline asynchronously. After the test filled the PTY until EAGAIN, the kworker could still free some space, so the next console write could succeed without discarding the unread output, and the test timed out waiting for the newest output. Write all of the output at once instead. The PTY cannot take all of it, so the last write always finds the buffer full. Fixes: 0b7e974 ("feat(console): redirect the guest console to a PTY") Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Coverage Report for CI Build 43105947891Coverage decreased (-0.005%) to 44.037%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, a kworker moves the output written to a PTY master into the line discipline asynchronously. After the test filled the PTY until EAGAIN, the kworker could still free some space, so the next console write could succeed without discarding the unread output, and the test timed out waiting for the newest output.
Write all of the output at once instead. The PTY cannot take all of it, so the last write always finds the buffer full.
Fixes: 0b7e974 ("feat(console): redirect the guest console to a PTY")