Repository navigation
feat(console): redirect the guest console to a PTY - #548
Merged
Merged
Conversation
`--console pty` connects the guest console to a pseudo-terminal, so a user can attach to it from another terminal, e.g. `screen /dev/pts/7`. The slave path is logged, and `link=<path>` creates a symbolic link to it at a stable path. The VMM keeps the slave open itself. Otherwise, on Linux, the master hangs up when the last client closes the slave, and reads fail with EIO. Writes from the guest never block. When the PTY buffer is full, the oldest output that nobody has read is dropped, so a client attaching late sees the newest output, e.g. the shell prompt. To do so, the VMM discards the unread output with tcflush() and writes back the newest 512 bytes, which it keeps in a small buffer. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--console ptyconnects the guest console to a pseudo-terminal, so a user can attach to it from another terminal, e.g.screen /dev/pts/7. The slave path is logged, andlink=<path>creates a symbolic link to it at a stable path.The VMM keeps the slave open itself. Otherwise, on Linux, the master hangs up when the last client closes the slave, and reads fail with EIO.
Writes from the guest never block. When the PTY buffer is full, the oldest output that nobody has read is dropped, so a client attaching late sees the newest output, e.g. the shell prompt. To do so, the VMM discards the unread output with tcflush() and writes back the newest 512 bytes, which it keeps in a small buffer.