Repository navigation
Conversation
|
Hi @klateefa @GWeale @DeanChensj — ready for review when you have a moment. This implements #5579: skill scripts that write files (reports/PDFs/exports) now have those outputs auto-saved as session artifacts, with |
|
@xuanyang15 -> ready for review. |
|
@a2105z Thanks for creating this PR! It is in review now. |
Skill scripts wrote files into a TemporaryDirectory that was deleted after execution, so generated PDFs/exports were lost. Capture new files from the script workspace, save them via tool_context.save_artifact, and return saved_artifacts in the tool result. Fixes google#5579
|
Rebased onto current What happened: the branch was behind
Unit tests were already green. No code changes in this push — rebase only. CI should be clean now. |
e819c71 to
140e5fa
Compare
|
@xuanyang15 — rebased onto latest |
|
Hi @xuanyang15 — quick question on CI for this PR. After the rebase, mypy and unit tests on 3.11–3.14 are green. The remaining reds look like they match current
Could you advise what you’d like us to do here? Happy to leave as-is and wait on the main fixes, or land a small drive-by in this PR if that’s preferred. Thanks! |
|
Hi @a2105z, no worries, we need to add some modification on top of your PR anyway internally, we will make sure all the CI checks pass for submission. |
|
Hi @xuanyang15 — thanks again for picking this up internally. Just a light follow-up: still happy to help with anything you need on our side so it can land. Appreciate it! |
Summary
__pycache__) via a stdout marker, andRunSkillScriptToolsaves them withtool_context.save_artifact.saved_artifactswhen persistence succeeds.Fixes #5579
Test plan
UnsafeLocalCodeExecutor+InMemoryArtifactService(save + no re-save of skill resources)test_skill_toolset.py(135 passed) + path traversal tests