Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
000b099 to
163ee24
Compare
|
The message ordering seems to be messed up when I use this Telling the agent to list our convo till now, and it list information in a wrong order. Which did not happen with the sync version |
163ee24 to
7274b0c
Compare
|
I believe this is because the MR is outdated, the logic of ordering has been changed some time ago. |
7274b0c to
087a5cc
Compare
087a5cc to
4a84596
Compare
|
Hi @condorcet and thanks to everyone who participated in this thread. We're currently doing some housekeeping on our pull request queue. Given the rapid pace of development and the number of updates since this was last active, there's a good chance this pull request needs to be caught up to the latest version. To help us keep our backlog focused on current pull requests, we are closing this as stale. If you're still interested in contributing to this change, could you please update to the very latest version of the library and create a new pull request? Our team will be glad to help with the refreshed PRs and answer any questions! Thanks for your contribution and understanding! |
Fixes issue #1005
Currently, database session service only has async / await interface, but internally it doesn't use async driver. For production usage it is critical, because database operations block the event loop.
This changes allows to use async drivers in database session service.
This also introduce some breaking changes:
initialize_tables) and not in__init__. In general such separation of concerns seems appropriate, since table initialization can be a separate process (it could be run before application startup, can be part of CI / CD, can use other DSN etc).