Repository navigation
[App Check] Add SPM AppCheckCore 12.x support - #626
Merged
Merged
Conversation
5 of 7 tasks
Contributor
|
Our next release (hopefully out by the end of this week) will move to 15! :) |
Member
Author
|
Oh great! I'll update this PR after that. We're still several weeks from the AppCheck update. cc: @ncooke3 |
ncooke3
reviewed
Aug 25, 2026
paulb777
force-pushed
the
pb-test-swift-app-check
branch
from
September 4, 2026 15:27
d7ed13c to
dd7b8ca
Compare
This was referenced Sep 4, 2026
paulb777
force-pushed
the
pb-test-swift-app-check
branch
from
September 22, 2026 23:04
dd7b8ca to
82b7331
Compare
ncooke3
reviewed
Sep 24, 2026
ncooke3
reviewed
Sep 24, 2026
ncooke3
reviewed
Oct 8, 2026
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
paulb777
changed the title
paulb777
marked this pull request as ready for review
October 8, 2026 15:15
ncooke3
reviewed
Oct 8, 2026
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
ncooke3
reviewed
Oct 8, 2026
ncooke3
approved these changes
Oct 8, 2026
This was referenced Oct 12, 2026
|
Hi @w-goog, thanks to @paulb777 and @ncooke3 for moving this along so quickly last week. @ncooke3's approval is in and CI is green, but GitHub still shows the PR as waiting on a required review, so I think it needs a sign-off from a GoogleSignIn maintainer before it can merge. Whenever you have a moment, could you take a look? We're planning our Firebase 13 upgrade around this change, so a rough idea of when the next release might ship would also help a lot. No pressure at all, and thank you! |
w-goog
self-requested a review
October 15, 2026 19:54
w-goog
approved these changes
Oct 15, 2026
w-goog
left a comment
w-goog
left a comment
Contributor
There was a problem hiding this comment.
Looks good :) Rather than add another review round, @ncooke3, I went ahead and made the following changes/additions:
- Added a test for the isPrepared fix (having "prepared" be related to !result.error lowk fixes a bug on AppCheckCore 11)
- Renamed the stale test, "testConfigureFailsNoTokenOrError"
- Removed a duplicate import.
- Added the PR links to the CHANGELOG, and noted in the changelog that I kept the "neither token nor error is now success". Since that only happens if a custom provider is misbehaving, I think that's OK...but I wanted Pods users to know about it.
Contributor
|
The AppCheck test job is hiding 403s, but that isn't new to this branch - we'll fix that separately, and revisit if there's a real regression. |
ncooke3
approved these changes
Oct 15, 2026
Member
|
Thanks @w-goog! |
|
Thanks @w-goog ! Hopefully we have a new release soon. 👍🏼 |
11 tasks done
1 task done
4 of 10 tasks
10 of 14 tasks
Contributor
|
Hi folks! 10.1.0 is now out on SPM, which contains this PR. |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 5, 2026
Widens the `GoogleSignIn-iOS` requirement from `9.0.0..<10.0.0` to `9.0.0..<11.0.0` in both the Swift package and the podspec (`~> 9.0` to `>= 9.0, < 11.0`), so apps can resolve GoogleSignIn 10, which allows `gtm-session-fetcher` 4.x and 5.x. GoogleSignIn 10 requires iOS 15 and macOS 12, and SwiftPM rejects a package whose dependency needs a higher platform than the package declares. This raises the plugin minimums to iOS 15 / macOS 12 (matching Flutter 3.47), updates the macOS example deployment targets, and updates the `google_sign_in` README support table, following #13292. Apps that also use firebase-ios-sdk 13 (no longer published to CocoaPods) need GoogleSignIn-iOS 10.1.0 or later, which includes google/GoogleSignIn-iOS#626 and widens App Check from 11.x to `11.0.0..<13.0.0`. The range here admits 10.1.0. Fixes flutter/flutter#194435 ## Pre-Review Checklist Versioning: `google_sign_in` only changes its README (support table) and macOS example, so it's listed under NEXT without a version bump, as in #13292. Test exemption: manual dependency update with no plugin code changes. The existing native and integration tests run against GoogleSignIn 10 once SwiftPM or CocoaPods resolves it. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate with AppCheckCore 12.x to enable interoperability with Firebase 13+. Firebase 12 interoperability remains
TODO: