Skip to content

Add delays to avoid potential race condition. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petea merged 1 commit into from
Apr 28, 2021
Merged

Add delays to avoid potential race condition. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions GoogleSignIn/Tests/Unit/GIDEMMErrorHandlerTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ - (void)testNoEMMError {
XCTAssertNil(_presentedViewController);
}

// TODO(petea): Figure out why we have a race condition for the first of these to run.
#if !SWIFT_PACKAGE

// Verifies that the handler handles general EMM error with user tapping 'OK'.
- (void)testGeneralEMMErrorOK {
__block BOOL completionCalled = NO;
Expand Down Expand Up @@ -366,6 +369,7 @@ - (void)testAppVerificationNoURL {
XCTAssertTrue(completionCalled);
}


// Verifies that the handler handles EMM app verification required error user tapping 'Cancel'.
- (void)testAppVerificationCancel {
__block BOOL completionCalled = NO;
Expand Down Expand Up @@ -460,6 +464,8 @@ - (void)testSequentialErrors {
[self testScreenlockRequiredCancel];
}

#endif

@end

NS_ASSUME_NONNULL_END