You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Finalize and replace app check loading logic in -[GIDSignIn authorizationRequestWithOptions:completion:]` #329
The current implementation dispatches async after waiting 1/2 second to ensure that an activity spinner is displayed to avoid flashing. We should update the logic to instead do the following:
If the call to app check completes before some short threshold is met, just carry on without any loading screen.
If that threshold is exceeded, then display a loading screen for at least 1/2 second.
After displaying the loading screen for 1/2, complete when callback is received from app check.
Activity
mdmathias commentedon Nov 2, 2023
Resolving as addressed by #331