Skip to content

Finalize and replace app check loading logic in -[GIDSignIn authorizationRequestWithOptions:completion:]` #329

Closed

Description

@mdmathias

The current implementation dispatches async after waiting 1/2 second to ensure that an activity spinner is displayed to avoid flashing. We should update the logic to instead do the following:

  1. If the call to app check completes before some short threshold is met, just carry on without any loading screen.
  2. If that threshold is exceeded, then display a loading screen for at least 1/2 second.
  3. After displaying the loading screen for 1/2, complete when callback is received from app check.

Activity

  1. self-assigned this
    on Jul 18, 2023
  2. mdmathias commented on Nov 2, 2023

    @mdmathias
    CollaboratorAuthor

    Resolving as addressed by #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions