Repository navigation
Add random sampling to dm_env array specifications - #24
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #14 by adding
sample(rng=None)to dm_env array specs for random values consistent with each spec, analogous to sampling Gym spaces.generate_value()remains unchanged and deterministic.Array.sample(): dtype-aware random sampling for boolean, integer (including fulluint64range), floating and complex arrays, at scalar or multidimensional shapes.BoundedArray.sample(): uniformly sample integer bounds inclusively, with scalar or elementwise broadcasting; uniformly sample finite floating bounds, and sample valid values when one or both bounds are infinite.DiscreteArrayinherits inclusive integer sampling, producing a valid action index.StringArray.sample()generates short random ASCIIstrorbytesstrings in the declared shape.numpy.random.Generatorto make sample sequences reproducible; without one, create a new generator. Reject unsupported nonnumeric plainArraydtypes rather than silently returning invalid values.generate_value()behavior in the API guide.Verification
dm_envtest directory, including the new randomized shape, dtype, bound, seeded reproducibility, discrete, empty-shape, string-type and infinity edge cases.This is an additive API; no existing sampling or environment behavior is replaced.