Skip to content

all: replace uses of deprecated io/ioutil package - #731

Merged
sbinet merged 1 commit into
gonum:masterfrom
sbinet-gonum:issue-709
Aug 19, 2021
Merged

sbinet merged 1 commit into
gonum:masterfrom
sbinet-gonum:issue-709

Conversation

@sbinet

@sbinet sbinet commented Aug 18, 2021

Copy link
Copy Markdown
Member

This CL has been mechanically applied through 'eg', to replace all uses
of io/ioutil.{Read,Write}File with os.{Read,Write}File, and similarly
for io/ioutil.Temp{Dir,File}.

Removal of io/ioutil.Discard has been applied manually.

Fixes #709.

(needs #728)

Please take a look.

@sbinet
sbinet requested a review from kortschak August 18, 2021 07:23
@codecov-commenter

codecov-commenter commented Aug 18, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #731 (20d98d1) into master (c96920b) will increase coverage by 2.36%.
The diff coverage is 83.54%.

❗ Current head 20d98d1 differs from pull request most recent head 68caf6e. Consider uploading reports for the commit 68caf6e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   70.78%   73.14%   +2.36%     
==========================================
  Files          60       58       -2     
  Lines        5291     5366      +75     
==========================================
+ Hits         3745     3925     +180     
+ Misses       1350     1248     -102     
+ Partials      196      193       -3     
Impacted Files Coverage Δ
cmpimg/checkplot.go 0.00% <0.00%> (ø)
plotter/quartile.go 70.09% <0.00%> (ø)
version.go 0.00% <ø> (ø)
font/font.go 56.42% <66.66%> (+0.54%) ⬆️
vg/vgsvg/vgsvg.go 65.59% <75.19%> (+5.01%) ⬆️
cmpimg/cmpimg.go 89.91% <78.94%> (+26.10%) ⬆️
vg/vggio/vggio.go 67.37% <82.85%> (-5.02%) ⬇️
axis.go 86.94% <100.00%> (+2.41%) ⬆️
legend.go 96.92% <100.00%> (ø)
plot.go 79.42% <100.00%> (+8.97%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e09f15...68caf6e. Read the comment docs.

Comment thread go.sum Resolved
@sbinet

sbinet commented Aug 19, 2021

Copy link
Copy Markdown
Member Author

PTAL

kortschak
kortschak previously approved these changes Aug 19, 2021
This CL has been mechanically applied through 'eg', to replace all uses
of io/ioutil.{Read,Write}File with os.{Read,Write}File, and similarly
for io/ioutil.Temp{Dir,File}.

Removal of io/ioutil.Discard has been applied manually.

Fixes gonum#709.
@sbinet
sbinet merged commit 382f0f7 into gonum:master Aug 19, 2021
@sbinet
sbinet deleted the issue-709 branch August 19, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all: replace ioutil.{Read,Write}File with os.{Read,Write}File

3 participants