Repository navigation

vg: remove {Add,Make}Font #696

Closed

opened

as #693 was proof, keeping vg.AddFont and vg.MakeFont is confusing.

they were kept because x/image/font/sfnt.Font didn't have the ability to give back access to the original []byte (or io.Reader) raw TTF data.

that's no longer the case thanks to https://go-review.googlesource.com/c/image/+/291149

remove AddFont
remove MakeFont
remove FontMap ?
remove vg/fonts (used by vgpdf)
remove use of vg.{Add,Make}Font{,Map} in vg/vgpdf
remove use of vg.{Add,Make}Font{,Map} in vg/vggio

(AFAICT, vg.FontMap is only used in plot/vg/vgpdf to embed fonts. with the x/image CL above being merged, we don't need vg.FontMap there either.)

sbinet
added a commit that references this issue on Jun 1, 2021
vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font
e086154
kortschak commented on Jun 1, 2021
kortschak
on Jun 1, 2021
Member
SGTM
sbinet
added 16 commits that reference this issue on Jun 1, 2021
vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font
19dda7f
vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font
c4b0a1a
vg/vgpdf: drop use of vg/fonts package
74aecbb
vg/vggio: drop use of vg/fonts package
3d8b8d2
vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font
c96920b
vg: remove FontMap, AddFont and MakeFont
92f1930
vg/vgpdf: drop use of vg/fonts package
2b7fd54
vg/vggio: drop use of vg/fonts package
021d7b3
vg/vgpdf: drop use of vg/fonts package
462f486
vg/vggio: drop use of vg/fonts package
aab80b2
vg/{fonts,vgpdf}: remove vg/fonts package
ad15ef3
vg: remove FontMap, AddFont and MakeFont
2fe641d
vg/vggio: drop use of vg/fonts package
e64c511
vg: remove FontMap, AddFont and MakeFont
e25766a
vg/vggio: drop use of vg/fonts package
db55d66
vg/{fonts,vgpdf}: remove vg/fonts package
d085374
stippi2 commented on Jun 10, 2021
stippi2
on Jun 10, 2021
JFYI: I've tried to have a plot rendered to SVG using another default font (plot.DefaultFont = font.Font{Typeface: "Arial"}). This was incredibly painful to get going up to a certain point. Along the way it just crashes, because FontFaces are accessed without checking if they are nil. To work around that, I needed to make font directories known to the vg package, then use vg.MakeFont() to obtain a Face, then register this face with the DefaultFontCache. Only to have it fail regardless, because the SVG renderer has a hard-coded, non-changeable map of type faces to CSS style strings. :-(
kortschak commented on Jun 10, 2021
kortschak
on Jun 10, 2021
Member
@stippi2 Please file an issue.
sbinet
added a commit that references this issue on Jun 24, 2021
vg/{fonts,vgpdf}: remove vg/fonts package
4e1c629
sbinet
added 4 commits that reference this issue on Aug 9, 2021
vg/{fonts,vgpdf}: remove vg/fonts package
a712f2f
vg/{fonts,vgpdf}: remove vg/fonts package
53fba7e
vg/{fonts,vgpdf}: remove vg/fonts package
9fca7f4
vg/{fonts,vgpdf}: remove vg/fonts package
a6e7cfd
sbinet
closed this as completedin #728 on Aug 19, 2021
sbinet
added a commit that references this issue on Aug 19, 2021
vg/{fonts,vgpdf}: remove vg/fonts package
d08bae0

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests