Repository navigation
fix(paint): bundle the bold, italic and bold-italic faces of Go Mono - #409
Merged
Merged
Conversation
The generic monospace had a regular style only, so bold and italic were lost on monospace text (go-slides terminal recordings, editable decks). The four styles of go-opentype/fonts gomono (BSD-3-Clause, Bigelow & Holmes, the same licence as the regular) now fill the four slots, loaded on demand like the others; webengine_fontsext lists three more files. Closes #403 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The bundled monospace face (Go Mono) was registered with a regular style only, so
font-weight: boldandfont-style: italicon genericmonospacetext were lost, in the raster, in PDF text and in the faces an editable PPTX/ODP records (#403).gomono.BoldTTF,ItalicTTFandBoldItalicTTFfrom go-opentype/fonts v0.14.0, the same family. Licence checked in that module's README table: Go Mono is BSD-3-Clause (Bigelow & Holmes, 2016), the same as the regular already bundled (it is not OFL; the family is not variable, so the weight axis of fix(paint): draw a variable font at the CSS font-weight #405 does not apply and the static files are used).BundledFontNamesandpaint/bundledfontslist three more files, sowebengine_fontsexthosts must serve them (13 -> 16 files).font()loses its now unreachable "bundled slot missing, use the regular" branch (paint stays at 100 percent).webengine_fontsextrow.Evidence
paint.TestBundledMonospaceStyles(fails on main: the four styles share one font): the four fonts are distinct, share Go Mono's fixed advance (layout does not move), a bold glyph carries clearly more ink than the regular, and the italic is not the upright shape.TestBundledFacesOnDemandnow asks for the bold italic face.go test ./...and thewebengine_fontsextbuild pass.Closes #403
Co-Authored-By: Claude Sonnet 5.5 noreply@anthropic.com
🤖 Generated with Claude Code