Repository navigation
rbtest: fail a refused load gate under -perf.run - #5
Merged
Merged
Conversation
An explicit timing request that measured nothing must not read as ok. Plain go test (no -perf.run) is unchanged. Fixes #4. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
With
-perf.run,rbtest.Perfnow fails (Fatalf, non-zero exit) when the load gate does not open, whether refused or still closed after-perf.wait. A gate that opens within the wait is unchanged. Without-perf.runnothing changes (CI unaffected).Tests: refuse mode fails and writes nothing; wait opening measures; wait timing out fails;
-perf.recordand plain mode pass under a busy load. rbtest coverage 100%. No flag change: PATCH.🤖 Generated with Claude Code