Repository navigation
fix: build on 32-bit targets (Calibrate's iteration bound) - #3
Merged
Merged
Conversation
maxIters = 1 << 40 does not fit an int on 386 and arm: the package failed to
compile there ("overflows int"), which broke every dependent's cross-compile
lanes (go-dsp/signal#10). The bound is now min(1<<40, MaxInt/2), and the scaled
count is bounded in float64 before the conversion to int.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case.go:94: maxIters (untyped int constant 1099511627776) overflows intonGOARCH=386andGOARCH=arm: found by go-dsp/signal#10's cross-compile and 386/arm lanes (v0.1.0 has no 32-bit lane of its own).maxIters = min(1<<40, math.MaxInt>>1): unchanged on 64-bit targets.int(...)(a float outside int's range converts to an unspecified value).errNoTime.GOOS=linux GOARCH=386|arm CGO_ENABLED=0 go test -cbuilds.Needs a patch release (v0.1.1) for the dependents.
🤖 Generated with Claude Code