Repository navigation
The bookmark grammar, and the Contents tab - #50
Merged
Merged
Conversation
ops v0.32.0 lifted the table-of-contents parser out of cmd/pdfops into the library as ParseOutline, and v0.33.0 split the nesting out of it as Nest, so a caller holding entries rather than a file reaches the same code. The operations page showed SetOutline and said nothing about how a table of contents is usually written down before it is a tree. The workbench page said ten tabs; there are eleven. Contents is the new one: the bookmarks the rail has always shown and the ribbon could only ever drop. Covers go-pdfkit/ops#76, go-pdfkit/ops#77 and go-pdfkit/app#94. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ops v0.32.0 lifted the table-of-contents parser out of
cmd/pdfopsinto the library asParseOutline, and v0.33.0 split the nesting out of it asNest, so a caller holding entries rather than a file reaches the same code. The operations page showedSetOutlineand said nothing about how a table of contents is usually written down before it is a tree — one entry a line, a title, a tab, a page number, two spaces of indent per level — nor that a line it cannot read is an error naming the line.The workbench page said ten tabs; there are eleven. Contents is the new one: the bookmarks the rail has always shown and the ribbon could only ever drop.
Refs go-pdfkit/ops#76, Refs go-pdfkit/ops#77, Refs go-pdfkit/app#94 — all three merged or open as the code this describes.
🤖 Generated with Claude Code