Repository navigation
docs(workbench): say which redacted files have to be re-made - #47
Merged
Merged
Conversation
Until go-pdfkit/ops v0.30.0 the words Redact removed were still in the saved file -- not on the page and invisible to every PDF reader, but present in an object nothing referenced, where grep finds them. The page already promised "the text is gone from the file, not covered", so it is the page that has to carry the correction: which builds are affected, the one-line check a reader can run on their own file, and the part people get wrong -- re-redacting the copy you still have does nothing about the copy you sent. Refs go-pdfkit/ops#74 -- the write-up of the defect and its range, closed because it is fixed; the warning here is for the files written before it was. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until ops v0.30.0 the words Redact removed were still in the saved file — not on the page and invisible to every PDF reader, but present in an object nothing referenced, where
grepfinds them.This page already promised "the text is gone from the file, not covered", so this is the page that has to carry the correction. It now says:
Refs go-pdfkit/ops#74 — the write-up of the defect and its range, closed because it is fixed; the warning here is for the files written before it was.
🤖 Generated with Claude Code