Repository navigation
ci: pin Go 1.27.1 instead of stable - #782
tannevaled wants to merge 1 commit into
Conversation
`stable` is a channel, not a version, so the toolchain moved here with no commit: CI has been building and running on go1.27.1 while go.mod said otherwise, and a MINOR Go bump is the one that reindents under gofmt and changes coverage block counting. It also kept the shared Renovate rule from ever firing. That rule matches dep name `go` under the `gomod` and `github-actions` managers with `automerge: false`, citing golang/go#81000 — and an alias has no version to compare or rewrite. Pinning is what makes the review rule apply at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Not my PR, so I am not merging it — two observations from the session that has been auditing docs-against-code on this repository tonight, both of which are cheap to fold in. 1. It leaves the README's Go badge stale. The badge and This PR's file list is 2. It raises the consumer floor one release after v0.1.0 promised 1.26.4. v0.1.0 shipped about an hour ago and its notes say "Requires Go 1.26.4 or later", which was true of that tag. Bumping the Checked, and clear: this does not collide with #781. That PR pins SHA256 sums for For what it is worth, the reasoning in the body is right and matches what this fleet has been bitten by before — 🤖 Generated with Claude Code |
|
Heads-up: this now shows CONFLICTING, and I caused it — I merged #783 (Renovate's Mentioning it rather than touching your branch: the resolution is yours to make, and a The substance of my earlier comment is unchanged: the README's Go badge ( 🤖 Generated with Claude Code |
|
Superseded: main moved and this branch conflicts. The same change (go 1.27.1, workflows pinned instead of |
go-version: stableis a channel alias, not a version, so this repository has been built and run ongo1.27.1with nothing in the tree saying so — and a minor Go bump is the one that reindents undergofmtand changes coverage block counting.It also kept the shared Renovate rule from ever firing: that rule matches dep name
gounder thegomodandgithub-actionsmanagers withautomerge: false, citinggolang/go#81000, and an alias has no version to compare or rewrite. Pinning is the condition for the review rule to apply at all, not rigidity.What to check before merging
CI is the control, and two lanes are worth a glance:
gofmt, if this repository gates it. A minor Go bump reindents; a patch does not.loong64under qemu, if this repository runs it.golang/go#81147, the 1.27 backport of the loong64 miscompile, is still open (milestone Go1.27.2) — verified in the released toolchain, whereLOONG64.rulesstill maps(Cvt64Fto32 ...)to(TRUNCDW ...)with all four float-to-integer ops declaredreg: fp11. A repository that only cross-compiles for loong64 cannot tell the difference, because a code-generation defect cannot redden a build that never runs.Pushed with
gitpush, because a workflow file cannot be written through the contents API with the tokenghholds: that one has noworkflowscope, and GitHub answers the PUT with a bare 404 naming neither.🤖 Generated with Claude Code