Skip to content

ci(native-arch): a lane that cannot check out the commit must fail, not report OK #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannevaled merged 1 commit into from
Oct 4, 2026
Merged

ci(native-arch): a lane that cannot check out the commit must fail, not report OK #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions .github/workflows/native-arch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,22 @@ jobs:
src="$(mktemp -d)"
git clone --depth 50 https://github.com/go-embedded-ruby/ruby "$src/ruby"
cd "$src/ruby"
git fetch --depth 50 origin "$COMMIT" || true
git checkout -q "$COMMIT" || echo "== commit $COMMIT not reachable; testing default branch HEAD"
# Fail closed. These two lines used to end in `|| true` and
# `|| echo "... testing default branch HEAD"`, which defeated the
# `set -euo pipefail` above on purpose: an unreachable $COMMIT -- a
# --depth miss, a force-push, or a workflow_dispatch off a branch --
# left the clone on whatever the default branch pointed at, ran the
# suite against THAT, and still printed "validation OK" at the end.
# A green tick that did not test its subject is worse than a red one,
# because nothing downstream can tell the difference.
git fetch --depth 1 origin "$COMMIT"
git checkout -q --detach "$COMMIT"
head="$(git rev-parse HEAD)"
if [ "$head" != "$COMMIT" ]; then
echo "== HEAD is $head but \$COMMIT is $COMMIT -- refusing to report on the wrong tree"
exit 1
fi
echo "== testing $head"

# ---- native validation --------------------------------------------------
export GOWORK=off CGO_ENABLED=0
Expand Down Expand Up @@ -279,8 +293,22 @@ jobs:
src="$(mktemp -d)"
git clone --depth 50 https://github.com/go-embedded-ruby/ruby "$src/ruby"
cd "$src/ruby"
git fetch --depth 50 origin "$COMMIT" || true
git checkout -q "$COMMIT" || echo "== commit $COMMIT not reachable; testing default branch HEAD"
# Fail closed. These two lines used to end in `|| true` and
# `|| echo "... testing default branch HEAD"`, which defeated the
# `set -euo pipefail` above on purpose: an unreachable $COMMIT -- a
# --depth miss, a force-push, or a workflow_dispatch off a branch --
# left the clone on whatever the default branch pointed at, ran the
# suite against THAT, and still printed "validation OK" at the end.
# A green tick that did not test its subject is worse than a red one,
# because nothing downstream can tell the difference.
git fetch --depth 1 origin "$COMMIT"
git checkout -q --detach "$COMMIT"
head="$(git rev-parse HEAD)"
if [ "$head" != "$COMMIT" ]; then
echo "== HEAD is $head but \$COMMIT is $COMMIT -- refusing to report on the wrong tree"
exit 1
fi
echo "== testing $head"

# ---- native validation --------------------------------------------------
export GOWORK=off CGO_ENABLED=0
Expand Down
Loading