Skip to content

fix(ui): log a folder emblem failure once and stop retrying when unsupported - #343

Merged
gnacho merged 1 commit into
mainfrom
fix/342-emblem-log-spam
Nov 15, 2026
Merged

gnacho merged 1 commit into
mainfrom
fix/342-emblem-log-spam

Conversation

@gnacho

@gnacho gnacho commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Closes #342. Inside the Flatpak sandbox the gvfs metadata daemon is absent, so set_folder_emblem fails on every write with setting the metadata::emblems attribute is not supported, and the state subscription fires on each change. The daily log filled with that line.

Now the subscription keeps two flags per folder: after an "unsupported" failure it stops writing emblems for that folder, and any failure is logged only once instead of on every state change. Truly transient failures (permissions, folder gone) still retry, so the emblem comes back if the cause disappears.

emblems_unsupported(message: &str) decides from the reported message, and has tests for the verbatim sandbox message plus lookalikes that must not be classified as unsupported (permission denied on the same attribute, a plain missing file).

Gates: cargo fmt --check, cargo clippy --all-targets -- -D warnings, and the full suite under Xvfb: 722 + 44 + 27 + 3 tests passing, 0 failures.

…pported

Inside the Flatpak sandbox there is no gvfs metadata daemon, so every emblem
write fails with "setting the metadata::emblems attribute is not supported".
The state subscription fires on each change, so the same line filled the
daily log with a harmless failure.

The subscription now stops writing emblems for that folder after such a
failure and logs it once. Other failures (permissions, missing folder) still
retry, because they can go away, but they are also logged only once per
folder so a transient error cannot flood the log either.

`emblems_unsupported` matches on the reported message, with tests for the
verbatim sandbox message and for lookalikes that must not be taken for it.

Closes #342
@gnacho
gnacho merged commit 6669745 into main Nov 15, 2026
2 checks passed
@gnacho
gnacho deleted the fix/342-emblem-log-spam branch November 15, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Folder emblems spam the log inside the Flatpak sandbox

1 participant