Skip to content

Pass the course window's height to the embed (steady height) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedricvogel-leo merged 1 commit into from
Nov 5, 2026
Merged

Pass the course window's height to the embed (steady height) #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,10 @@ window.__glpythonMount = (args, send) => {
const query = new URLSearchParams({ parentOrigin: window.location.origin, mode, lang: language })
if (visualizerMode) query.set("visualizer", visualizerMode)
if (featuresOption) query.set("features", requestedFeatures.filter((name) => featureNames.includes(name)).join(","))
// The course window's height, which the iframe can't see: while
// visualizing, the embed keeps one height (that of the tallest step), at
// most 80% of it - a taller step scrolls inside the visualizer.
query.set("windowHeight", String(window.innerHeight))
if (large) {
query.set("size", "large")
query.set("visualizerHeight", String(largeVisualizerHeight))
Expand Down Expand Up @@ -1080,6 +1084,12 @@ readers.
`large` makes the code 20px (line height 1.6) and the visualizer at least 60% of
the window, e.g. for the projector in presentation mode.

While stepping through a visualization, the block keeps one height, so the
course page doesn't move: the visualizer is as tall as the tallest step from
the start, and the console as tall as the output at the last step. The
visualizer is at most 80% of the course window; a taller step (e.g. a deep
recursion in «Kasten») scrolls inside it, following the current step.

A course builds its own profiles from these options as macros in its header,
passing `@0` on so a block can add more options (a mode or library URLs):

Expand Down
Loading