Skip to content

Visual blocks: start at their final height (no shrinking) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedricvogel-leo merged 1 commit into from
Oct 25, 2026
Merged

Visual blocks: start at their final height (no shrinking) #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,16 @@ comment: Embed the glpython editor, execution visualizer, and turtle graphics
const unknownFeatures = requestedFeatures.filter((name) => !featureNames.includes(name))
const hasFeature = (name) => requestedFeatures.includes(name)
const large = options.includes("large")
// "large": the visualizer at least 60% of the window - the slide in
// LiaScript's presentation mode - passed in pixels, since the iframe's
// own height follows its content.
const largeVisualizerHeight = Math.round(window.innerHeight * 0.6)
// A visualization-only block starts at the height a short visualization
// ends up with (with "large": its visualizer's), and never gets smaller.
// Until its trace arrives, the embed reports only its loading state
// (160px), so the iframe would first shrink and then grow again - in a
// course e.g. right when a quiz's solution opens.
const minHeight = mode !== "visual" ? 170 : large ? largeVisualizerHeight : 190
// The course's own language (its "language:" header, which LiaScript sets
// as the page's lang attribute), else the browser's, else English. Only the
// primary subtag counts ("de-CH" -> "de"); an unsupported language such as
Expand Down Expand Up @@ -361,7 +371,7 @@ comment: Embed the glpython editor, execution visualizer, and turtle graphics
} else if (message.type === "glpython:resize" && Number.isFinite(message.height)) {
// The embed's height follows its content (the visualizer too, unless
// "large" asks for 60% of the window).
frame.style.height = `${Math.max(170, Math.min(message.height, 1200))}px`
frame.style.height = `${Math.max(minHeight, Math.min(message.height, 1200))}px`
} else if (message.type === "glpython:error") {
showError(message.message || strings.embedError)
}
Expand Down Expand Up @@ -484,17 +494,14 @@ comment: Embed the glpython editor, execution visualizer, and turtle graphics
libraries.then(showLibraries)
if (frame.dataset.glpythonInitialized === "true") return
frame.dataset.glpythonInitialized = "true"
if (mode === "visual") frame.style.height = "420px"
if (mode === "visual") frame.style.height = `${minHeight}px`
frame.title = `${strings.frameTitle} (${mode})`
const query = new URLSearchParams({ parentOrigin: window.location.origin, mode, lang: language })
if (visualizerMode) query.set("visualizer", visualizerMode)
if (featuresOption) query.set("features", requestedFeatures.filter((name) => featureNames.includes(name)).join(","))
// "large": the visualizer at least 60% of the window - the slide in
// LiaScript's presentation mode - passed in pixels, since the iframe's
// own height follows its content.
if (large) {
query.set("size", "large")
query.set("visualizerHeight", String(Math.round(window.innerHeight * 0.6)))
query.set("visualizerHeight", String(largeVisualizerHeight))
}
frame.src = `${embedUrl}?${query}`
}
Expand Down
Loading