Skip to content

Fix Markdown source loading in glpython macros #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedricvogel-leo merged 2 commits into from
Oct 20, 2026
Merged

Fix Markdown source loading in glpython macros #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f8b5e1
Fix LiaScript macro source forwarding
cedricvogel-leo Oct 20, 2026
cedfc79
Read source from LiaScript editor element
cedricvogel-leo Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ language: en
comment: Embed the glpython editor, execution visualizer, and turtle graphics
in LiaScript courses.

@GLPython.eval: @GLPython.embed(@uid,eval,```@0```)
@GLPython.eval: @GLPython.embed(@uid,eval)

@GLPython.turtle: @GLPython.embed(@uid,turtle,```@0```)
@GLPython.turtle: @GLPython.embed(@uid,turtle)

@GLPython.embed
<script run-once>
Expand All @@ -19,11 +19,15 @@ comment: Embed the glpython editor, execution visualizer, and turtle graphics
const embedUrl = `${embedOrigin}/glpython-editor/index.html`
const frame = document.getElementById("glpython-frame-@0")
const error = document.getElementById("glpython-error-@0")
const source = String.raw`@2`
const mode = "@1"
const nativeCodeBlock = frame
.closest(".lia-slide__content")
?.querySelector(".lia-code--block")
const codeBlocks = [
...(frame.closest(".lia-slide__content")?.querySelectorAll(".lia-code--block") ?? []),
]
const nativeCodeBlock = codeBlocks.findLast((block) =>
block.compareDocumentPosition(frame) & Node.DOCUMENT_POSITION_FOLLOWING
)
const nativeEditor = nativeCodeBlock?.querySelector("lia-editor")
const source = typeof nativeEditor?.value === "string" ? nativeEditor.value : null
if (nativeCodeBlock) nativeCodeBlock.hidden = true

const showError = (message) => {
Expand All @@ -46,6 +50,11 @@ comment: Embed the glpython editor, execution visualizer, and turtle graphics
if (!message || message.version !== protocolVersion) return

if (message.type === "glpython:ready") {
if (source === null) {
showError("The LiaScript source block could not be read.")
send.lia("LIA: stop")
return
}
const inputAvailable = message.capabilities?.input === true
frame.dataset.inputAvailable = String(inputAvailable)
if (!inputAvailable && /(^|[^\w])input\s*\(/.test(source)) {
Expand Down