Skip to content

GitConfigParser.set_value should support setting multiple values for an option #717

Closed
Closed
GitConfigParser.set_value should support setting multiple values for an option#717
Labels
acknowledgedenhancementhelp wanted
Milestone
v3.0.0 - Remove Python 2

Description

@craftyguy
craftyguy
opened on Jan 16, 2018

GitConfigParser.set_value does not allow for setting multiple values for a given option.
One example of this is in the refspec documentation for git:

remote "origin"]
	url = https://github.com/schacon/simplegit-progit
	fetch = +refs/heads/master:refs/remotes/origin/master
	fetch = +refs/heads/experiment:refs/remotes/origin/experiment

If you try to call set_value twice with the two different refspecs above, only the last one will get set.. which makes sense since set_value seems to only support setting one value for a given option.

Activity

  1. ajdavis commented on Jan 6, 2019

    @ajdavis
    ajdavis
    on Jan 6, 2019
    Contributor

    I can make a pull request for this, are the maintainers interested?

  2. Byron
    added
    acknowledged
    enhancement
    help wanted
    on Jan 12, 2019

  3. Byron commented on Jan 12, 2019

    @Byron
    Byron
    on Jan 12, 2019
    Member

    @ajdavis Yes, I am absolutely interested. The implementation will certainly require some effort. In order not to break the existing API, it might be easiest to add methods specifically for getting and setting multiple values.

  4. ajdavis
    added 3 commits that reference this issue on Jan 21, 2019

    Support multiple git config values per option

    f7bbe6b

    Python 3 compatibility

    a26349d

    Use items and items_all correctly

    4106f18

  5. maiamcc commented on Jul 3, 2019

    @maiamcc
    maiamcc
    on Jul 3, 2019

    FWIW, tangential to this ticket but I'd also appreciate it if there were a way to GET multiple values for a given option (equivalent to git config --get-all). Should I open a new issue?

  6. Byron
    added this to the v2.1.12 - Bugfixes milestone on Jul 20, 2019

  7. Byron commented on Jul 20, 2019

    @Byron
    Byron
    on Jul 20, 2019
    Member

    By now this is implemented thanks to a generous PR.

  8. Byron
    closed this as completedon Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    acknowledgedenhancementhelp wanted

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions