Diff fails on empty repository. #41

Activity

1. fcelda commented on Mar 21, 2012

   

   fcelda

   on Mar 21, 2012

   Contributor

   More actions

   Actually, diff() works just fine. If you add some files into the index, you have to append staged (or cached) parameter to make diff to show the changes.

   >>> r.index.diff(None, staged=True)
   [<git.diff.Diff object at 0x2a86c80>]

   But is_dirty() behaves inconsistently. It should indeed return False. My patch (1253036) fixes it. But I'm unable to run your nose tests and therefore I cannot update them. Hope this helps:

   #!/usr/bin/python
   
   import git
   import os
   
   os.system("rm -rf repo/")
   r = git.Repo.init("repo")
   os.system("echo foo > repo/foo")
   os.system("echo bar > repo/bar")
   
   assert not r.is_dirty()
   
   r.index.add(["foo"])
   assert r.is_dirty()
   
   r.index.commit("foo messsage")
   assert not r.is_dirty()
   
   r.index.add(["bar"])
   assert r.is_dirty()
2. nemec commented on Mar 22, 2012

   

   nemec

   on Mar 22, 2012

   Author

   More actions

   Ah, I must have missed out on the staged keyword in the docs. Thanks.
3. maxyz

   added 2 commits that reference this issue on Sep 29, 2014

   Fix issue gitpython-developers#41: repo.is_dirty() on empty repositor…

   ...

   f9ec0af

   Fix issue gitpython-developers#41: repo.is_dirty() on empty repositor…

   ...

   6c9fcd7
4. Byron

   added 2 commits that reference this issue on Nov 14, 2014

   Merge pull request #193 from maxyz/fix-issue-41_master

   ...

   6620d9f

   Merge pull request #194 from maxyz/fix-issue-41_0.3

   ...

   9044abc
5. Byron

   added this to the v0.3.5 - bugfixes milestone on Nov 19, 2014
6. Byron

   added

   acknowledged

   on Nov 19, 2014
7. Byron commented on Nov 19, 2014

   

   Byron

   on Nov 19, 2014

   Member

   More actions

   Even though plenty of work has been done on this already, there is no test-case yet to truly verify this works. It should be done when working on 0.3.5.
8. Byron commented on Jan 8, 2015

   

   Byron

   on Jan 8, 2015

   Member

   More actions

   A lot of time has passed, and plenty of changes were applied to is_dirty(). Additionally, there are plenty of tests checking all aspects of it.
   Therefore I believe this issue can be closed for now.
9. Byron

   closed this as completedon Jan 8, 2015
10. govtech42

    added 2 commits that reference this issue on Jul 25, 2026

    Merge pull request gitpython-developers#41 from nooperpudd/master

    ...

    7f216d9

    Replace use of mktemp

    ...

    a315725