incorrect 'git' version for GitPython==3.1.28 installed from PyPI #1500

Activity

1. branfosj commented on Oct 10, 2022

   

   branfosj

   on Oct 10, 2022

   Last edited by branfosj

   More actions

   In 21ec529 there is the change:

   -__version__ = 'git'
   +__version__ = "git"
    
    
   -#{ Initialization
   +# { Initialization
    def _init_externals() -> None:
        """Initialize external projects by putting them into the path"""
   -    if __version__ == 'git' and 'PYOXIDIZER' not in os.environ:
   -        sys.path.insert(1, osp.join(osp.dirname(__file__), 'ext', 'gitdb'))
   +    if __version__ == "git" and "PYOXIDIZER" not in os.environ:
   +        sys.path.insert(1, osp.join(osp.dirname(__file__), "ext", "gitdb"))

   However, setup.py puts the version in by doing a find/replace with a search for 'git':

   line = line.replace("'git'", "'%s'" % VERSION)

   and that fails, which leaves "git" in two places in __init__.py.
2. Byron

   added a commit that references this issue on Oct 10, 2022

   fix version replacement in `setup.py` (#1500)

   ...

   be3400b
3. Byron

   added

   acknowledged

   on Oct 10, 2022
4. Byron

   added this to the v3.1.29 - Bugfixes milestone on Oct 10, 2022
5. Byron commented on Oct 10, 2022

   

   Byron

   on Oct 10, 2022

   Member

   More actions

   Thanks for letting me know! This should be fixed with v3.1.29, please let me know in the comments if it isn't though.
6. Byron

   closed this as completedon Oct 10, 2022
7. boegel commented on Oct 11, 2022

   

   boegel

   on Oct 11, 2022

   ContributorAuthor

   More actions

   I can confirm that a proper versio is printed for GitPython 3.1.29, thanks a lot for the quick fix!

   $ pip3 install GitPython==3.1.29
   $ python3 -c 'import git; print(git.__version__)'
   3.1.29