Skip to content

typing-extensions dependency not correct? #1274

Closed
#1275
Closed
typing-extensions dependency not correct?#1274
#1275
Milestone
v3.1.19 - Bugfixes

Description

@wardy3
wardy3
opened on Jun 22, 2021

Hi

I am getting this error:

   from git import Repo
1361/usr/local/lib/python3.7/site-packages/git/__init__.py:8: in <module>
1362    from git.exc import *                       # @NoMove @IgnorePep8
1363/usr/local/lib/python3.7/site-packages/git/exc.py:10: in <module>
1364    from git.compat import safe_decode
1365/usr/local/lib/python3.7/site-packages/git/compat.py:32: in <module>
1366    from git.types import TBD
1367/usr/local/lib/python3.7/site-packages/git/types.py:12: in <module>
1368    from typing_extensions import Final, Literal, SupportsIndex  # noqa: F401
1369E   ImportError: cannot import name 'SupportsIndex' from 'typing_extensions' (/usr/local/lib/python3.7/site-packages/typing_extensions.py)

I think it's because the dependency is listed as 3.7.4.0 but SupportsIndex wasn't added until May 2020, which looks like 3.7.4.3?

thanks for the great work

Activity

  1. Yobmod commented on Jun 23, 2021

    @Yobmod
    Yobmod
    on Jun 23, 2021
    Contributor

    Thanks for posting.

    I've updated the typing-extensions dependancy to 3.7.4.3 (released Aug 2020)
    Again the tests all pass because they use the most recent minor versions, but there are API changes in minor versions.

    I guess for users it will be easier to update typing-extensions than gitpython, so doesnt need another release just for this.

  2. wardy3 commented on Jun 23, 2021

    @wardy3
    wardy3
    on Jun 23, 2021 via email
    Author
  3. Byron
    closed this as completedin #1275on Jun 23, 2021
  4. Byron
    added this to the v3.1.19 - Bugfixes milestone on Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions