Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.
This repository was archived by the owner on May 30, 2024. It is now read-only.

Provide the browser notification #261

Closed

Description

@noahingh

At this moment, we're providing the Slack notification for deployments and reviews, but it is possible to provide the browser notification.

The notification logic is determined by the kind (deployment or review). The browser should notify only the user who triggers the deployment for the' deployment' event. For the review event, it should notify the requester when the review is responded to, but it should notify the reviewer when the review is requested.

Implement

We should implement two parts for the browser notification like the below:

  1. Provide the setting to configure the notification whether to receive or not.
  2. Notify the user when the event is fired.

Activity

  1. added this to the v0.5 milestone on Dec 15, 2021
  2. added
    component: uiThis issue or pull request is related to the feature of the UI-side
    on Dec 15, 2021
  3. linked a pull request that will close this issueProvide the browser notification for events #268on Dec 18, 2021
  4. added
    enhancementNew feature or request
    and removed
    component: uiThis issue or pull request is related to the feature of the UI-side
    on Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions