Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.
This repository was archived by the owner on May 30, 2024. It is now read-only.

Reconsider the review system of Gitploy. #185

Closed

Description

@noahingh

We should provide some features to enhance the review system.

Note

When I started to design the review system, I thought it was reasonable to deploy automatically after approval like GitHub. But for Gitploy, it is not feasible because Gitploy has the validation of GitHub deployment API, which can fail to deploy automatically. So we should deploy it manually.

Todo

Activity

  1. added this to the v0.3 milestone on Oct 25, 2021
  2. changed the title [-]Enable to leave the comment with the review.[/-] [+]Change deploying automatically after review.[/+] on Nov 6, 2021
  3. changed the title [-]Change deploying automatically after review.[/-] [+]Leave the comment with the review[/+] on Nov 6, 2021
  4. changed the title [-]Leave the comment with the review[/-] [+]Reconsider the review system of Gitploy.[/+] on Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions