Repository navigation
refactor!: meta_git_cli follows meta_core's single config name - #36
Merged
Merged
Conversation
meta discovers its config only as .meta.yaml (and, until Matt confirms its removal, .meta.yml). The .meta and .meta.json names, the JSON parse path and ConfigFormat are gone: every config is parsed as YAML, which reads JSON content too. A folder with only .meta or .meta.json is not a workspace. BREAKING CHANGE: rename a .meta or .meta.json config to .meta.yaml (same content). [[tasks/harmony-2878]]
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Review round 2. [[tasks/harmony-2878]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call sites follow meta_core's
Option<PathBuf>API. Fixtures write.meta.yaml, and messages and help say.meta.yaml.Part of gitkb/meta#132 (meta reads only
.meta.yaml), which has the reasoning, the breaking-change note and the verification. Merge together with it.Task:
[[tasks/harmony-2878]]Need help on this PR? Tag
@codesmith-botwith what you need.