Skip to content
This repository was archived by the owner on Jun 3, 2026. It is now read-only.
This repository was archived by the owner on Jun 3, 2026. It is now read-only.

Markdown block breaks for some syntax #65

Open

Description

@jaked

MDX is pickier about syntax than GitHub-Flavored Markdown:

  • it doesn't accept unclosed tags, so e.g. unclosed <img> tags are not supported (example, example)
  • "Expected Unicode escape sequence \uXXXX" (example)

Activity

  1. changed the title [-]Markdown block breaks for some syntax (e.g. https://blocks.githubnext.com/api/auth/signin?callbackUrl=http%3A%2F%2Flocalhost%3A8080%2Fsourcegraph%2Fsourcegraph, http://blocks.githubnext.com/preactjs/preact?branch=master&blockKey=githubnext__blocks-examples__overview-block)[/-] [+]Markdown block breaks for some syntax[/+] on Jul 28, 2022
  2. Wattenberger commented on Aug 8, 2022

    @Wattenberger
    Contributor

    note: this is handled in the new Markdown-edit Block, and we might not need to tackle this if we're replacing the old Markdown Preview Block

  3. jaked commented on Aug 15, 2022

    @jaked
    Author

    huh does the new Markdown-edit block use something other than MDX to render pages? I would expect to see the same bug otherwise.

  4. Wattenberger commented on Aug 15, 2022

    @Wattenberger
    Contributor

    it does! it's just CodeMirror with a bunch of custom plugins and a Markdown parser

  5. jaked commented on Aug 16, 2022

    @jaked
    Author

    whoa! gotta read that code

  6. tattwamasi commented on Feb 1, 2023

    @tattwamasi

    Not sure if it's the same issue or not, but noted the tables in the examples repo weren't rendering properly in blocks, but were in the normal site.

    Screenshot 2023-01-31 at 4 36 20 PM

    Screenshot 2023-01-31 at 4 36 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions