filepath.Walk() no space left on device #23

Activity

1. githubnemo commented on Jan 26, 2017

   

   githubnemo

   on Jan 26, 2017

   Last edited by githubnemo

   Owner

   More actions

   That is unexpected.

   Any special things concerning your environment? OS? What file system are you using?
2. cameracker commented on Jan 31, 2017

   

   cameracker

   on Jan 31, 2017

   Author

   More actions

   Sorry for the delay.

   After a few reboots and such I determined that running the command in visual studio code's integrated terminal causes this problem, and in some unknown cases can cause CompileDaemon to yield this error until reboot. I'm not sure what about VSC causes the error, or why it is permanent sometimes but I think it can be worked around by simply not running it in VSC :)
3. githubnemo commented on Jan 31, 2017

   

   githubnemo

   on Jan 31, 2017

   Owner

   More actions

   Well, that's odd.

   So I assume you are starting CompileDaemon more than once in the VSC terminal? Because Walk() is only called once at the beginning. Maybe there are other instances of CompileDaemon lingering in the background, eating up all free file descriptors and at the end, Walk() in the new instance cannot open any more files?
4. cameracker commented on Jan 31, 2017

   

   cameracker

   on Jan 31, 2017

   Author

   More actions

   In this case we only use CompileDaemon for one specific component of our software and only use it there. So there should have only been one instance.

   I suspected that there was a lingering instance initially, but couldn't find evidence of that using ps or any other task manager. And it doesn't explain why after a reboot ->VSC start it'd be busted. I'll keep poking at it and will share anything interesting I find, but I don't know if there's anything in particular to figure out.

   Thanks for paying attention to this :)
5. robbert229 commented on Mar 7, 2017

   

   robbert229

   on Mar 7, 2017

   More actions

   Encountered the same issue on a fresh reboot. Not using VSCode but I am using Atom.
6. githubnemo commented on Mar 7, 2017

   

   githubnemo

   on Mar 7, 2017

   Owner

   More actions

   @robbert229 any infos on the environment you are using? How do you invoke CD?
7. robbert229 commented on Mar 7, 2017

   

   robbert229

   on Mar 7, 2017

   More actions

   I am running Arch Linux, and I was attempting to invoke

   CompileDaemon -exclude-dir=./minio-data -exclude-dir=./neo4j-data -color -build="go build -o api.exe server" -command="npm run api" -graceful-kill=true -log-prefix=false
   

   Edit

   Found the solution! It turns out that -exclude-dir wouldn't exclude the desired directories, this is because of the ./ prefixing the directory name.The flag -exclude-dir=./vendor wouldn't ignore the vendor directory

   Will looking through the source for the cause of my problems I saw that filepath.Walk had somthing interesting in it. info.Name() returns the name of the file. If it was walking over ./vendor/aws/foo.go it would be foo.go, is this intended behavior?

   err = filepath.Walk(*flag_directory, func(path string, info os.FileInfo, err error) error {
   	if err == nil && info.IsDir() {
   
   		if flag_excludedDirs.Matches(info.Name()) {
   			return filepath.SkipDir
   		} else {
   			fmt.Printf("Adding: %s\n", path)
   			return watcher.Add(path)
   		}
   	}
   	return err
   })
   
8. githubnemo commented on Mar 7, 2017

   

   githubnemo

   on Mar 7, 2017

   Owner

   More actions

   This problem would be detected earlier if CD had a verbose mode, plotting the watched directories. Good job at identifying the problem, I haven't looked into it yet but this looks promising. I will look into this momentarily.
9. githubnemo

   closed this as completedin d447e56on Mar 8, 2017
10. githubnemo commented on Mar 8, 2017

    

    githubnemo

    on Mar 8, 2017

    Last edited by githubnemo

    Owner

    More actions

    @robbert229 thanks for finding the actual issue behind this problem! It should be fixed now.
11. mrosentr commented on Mar 15, 2017

    

    mrosentr

    on Mar 15, 2017

    More actions

    I still have this issue with Ubuntu 16.04 64bit after recompiling fix#23.
12. githubnemo commented on Mar 15, 2017

    

    githubnemo

    on Mar 15, 2017

    Owner

    More actions

    @mrosentr Can you paste the command line of how you invoke CD and the output when starting with -verbose?
13. mrosentr commented on Mar 15, 2017

    

    mrosentr

    on Mar 15, 2017

    More actions

    I use this one primarily:
    CompileDaemon -directory=. -build="go build -o server" -command="./server" -color=true -verbose

    Have also tried this:
    CompileDaemon -directory=/path-to-source -build="go build -o server" -command="./server" -color=true -verbose

    Output:
    2017/03/15 14:22:17 Watching directory '.' for changes.
    2017/03/15 14:22:17 filepath.Walk():no space left on device
14. githubnemo commented on Mar 15, 2017

    

    githubnemo

    on Mar 15, 2017

    Owner

    More actions

    A gotcha. This is from fsnotify.Watcher.Add() which roughly translates to the inotify_add_watch syscall which describes the failure mode ESPC as follows:

    ENOSPC The user limit on  the  total  number  of  inotify  watches  was
            reached or the kernel failed to allocate a needed resource.
    

    Consider increasing the number of possible inotify watches.

    👍React with 👍1Reacted by Eren ÇAY
15. mrosentr commented on Mar 16, 2017

    

    mrosentr

    on Mar 16, 2017

    More actions

    Increasing the inotify watches worked! ty!
16. sevkin commented on Aug 7, 2017

    

    sevkin

    on Aug 7, 2017

    More actions

    @githubnemo plz add solution about fs.inotify.max_user_watches in notes section of readme

    👍React with 👍3Reacted by kamyarkaviani, Igor Shmel and Bayu Candra
17. githubnemo

    added a commit that references this issue on Oct 11, 2020

    Document solution for #23

    bc283d0