Repository navigation
Expression syntax highlighting doesn't seem to respect comments #158
Description
Describe the bug
Here, this line should appear as a comment:
To Reproduce
Here's the text:
update-rust-toolchain:
runs-on: ubuntu-latest
# Don't run on forks; will attempt to create a PR into the fork...
# if: ${{ !github.event.pull_request.head.repo.fork }}Extension Version
v0.25.6
Activity
[-]`if` expression syntax highlighting doesn't seem to respect comments[/-][+]Expression syntax highlighting doesn't seem to respect comments[/+]cschleiden commentedon May 8, 2023
Currently we always syntax highlight expressions in comments, that's not just limited to
ifexpressions. It's due to the way we inject into the yaml grammar.Since adding
GitHub Actions Workflowsas a separate language we could modify the yaml tm grammar if we wanted to.muzimuzhi commentedon May 9, 2023
Did you mean "as a separate language"?
scott-doyland-burrows commentedon May 31, 2023
I noticed this as well, this just looks odd:
The entire comment should be shown in green, in my opinion.