Repository navigation
fix(coordinator): add routing enforcement refusal rule - #890
Merged
Merged
Conversation
Contributor
🟠 Impact Analysis — PR #890Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
root (1 file)
squad-cli (1 file)
squad-sdk (1 file)
templates (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit refusal rule to strengthen coordinator routing enforcement so the coordinator delegates work to team members rather than performing domain work inline.
Changes:
- Added a 4th refusal rule requiring delegation (except Direct Mode factual answers already in context).
- Synced the updated coordinator prompt across all tracked template copies.
- Recorded the change and rationale in Procedures history.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.github/agents/squad.agent.md |
Adds the new refusal rule to the canonical coordinator agent prompt. |
templates/squad.agent.md.template |
Syncs the refusal rule into the root template copy. |
packages/squad-cli/templates/squad.agent.md.template |
Syncs the refusal rule into the CLI-distributed template copy. |
packages/squad-sdk/templates/squad.agent.md.template |
Syncs the refusal rule into the SDK-distributed template copy. |
.squad-templates/squad.agent.md |
Syncs the refusal rule into the .squad-templates tracked copy. |
.squad/agents/procedures/history.md |
Documents the routing-enforcement hardening and lists updated files. |
diberry
force-pushed
the
squad/853-coordinator-routing-enforcement
branch
from
April 8, 2026 14:25
23889f3 to
1fdeac2
Compare
diberry
force-pushed
the
squad/853-coordinator-routing-enforcement
branch
from
April 8, 2026 15:54
1fdeac2 to
d2d3066
Compare
diberry
force-pushed
the
squad/853-coordinator-routing-enforcement
branch
from
April 8, 2026 16:42
d2d3066 to
745c705
Compare
Contributor
Author
🔍 Squad Review — Kaylee (Engineering)
Verdict: ✅ Ready to merge Review by Squad AI team (Kaylee — Engineering) · requested by Dina Berry |
Contributor
Author
|
✅ CI validation passed on fork: diberry#144 — 7/7 checks green |
tamirdresher
pushed a commit
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Dina Berry <diberry@users.noreply.github.com>
Open
7 tasks done
martinopedal
referenced
this pull request
in martinopedal/FinOps-assessment
May 12, 2026
Adopts the routing-enforcement clause from upstream squad-cli v0.9.4 (PR bradygaster/squad#890) as anti-pattern #6 in .github/agents/squad.agent.md. Bumps version stamp v0.8.25 → v0.8.25+local to reflect the local-cherry-pick posture; full v0.9.4 wholesale upgrade remains out of scope per the squad-cli audit (issue #26 / decisions.md). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
martinopedal
referenced
this pull request
in martinopedal/FinOps-assessment
May 12, 2026
* chore(squad): adopt routing-enforcement refusal rule (#35) Adopts the routing-enforcement clause from upstream squad-cli v0.9.4 (PR bradygaster/squad#890) as anti-pattern #6 in .github/agents/squad.agent.md. Bumps version stamp v0.8.25 → v0.8.25+local to reflect the local-cherry-pick posture; full v0.9.4 wholesale upgrade remains out of scope per the squad-cli audit (issue #26 / decisions.md). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * update(squad/sam): append learning from issue #35 completion --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #853
Problem
The coordinator sometimes does domain work itself instead of dispatching to team members. Some models interpret existing refusal rules loosely.
Fix
Added explicit refusal rule:
Also confirmed the Init Mode 3-state check (zero roster entries) was already present in all copies — no change needed.
Files Changed
.github/agents/squad.agent.md— added 4th refusal rule (canonical)templates/squad.agent.md.template— syncedpackages/squad-cli/templates/squad.agent.md.template— syncedpackages/squad-sdk/templates/squad.agent.md.template— synced.squad-templates/squad.agent.md— synced (5th tracked copy).squad/agents/procedures/history.md— session learningsWorking as Procedures (Prompt Engineer)