Skip to content

fix(cli): warn when squad watch receives unused message args (#703) - #858

Closed
diberry wants to merge 1 commit into
devfrom
squad/704-watch-message-warning
Closed

diberry wants to merge 1 commit into
devfrom
squad/704-watch-message-warning

Conversation

@diberry

@diberry diberry commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

What

Detects extra positional args passed to squad watch and prints a clear warning instead of silently ignoring them.

Why

Users expect squad watch --interval 5 "Nick, Run scheduled tasks" to route the message to agent Nick on each poll cycle. But watch mode only runs Ralph polling loop — the quoted message is silently dropped. This caused confusion (reported by community user).

How

Makes the existing positional-arg detection (previously verbose-only) always warn with a clear UX message:

⚠️  Watch mode does not route messages to agents. Ignoring: "Nick, Run scheduled tasks"
   To address an agent directly, use an interactive session instead.

Files Changed

  • packages/squad-cli/src/cli-entry.ts — warning always shown (was verbose-only)
  • CHANGELOG.md — changelog entry
  • docs/src/content/docs/features/ralph.md — caution admonition
  • docs/src/content/docs/reference/cli.md — CLI reference note
  • .changeset/watch-message-warning.md — changeset

Closes #703

Based on PR #704 by @tamirdresher

Co-authored-by: tamirdresher
Co-authored-by: Copilot

Copilot AI review requested due to automatic review settings April 5, 2026 17:53
@github-actions

github-actions Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 85dc7c8

⚠️ 2 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved 0 active Copilot thread(s) resolved (3 outdated skipped)
❌ CI passing 16 check(s) still running

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

github-actions Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #858

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 4
Files added 1
Files modified 3
Files deleted 0
Modules touched 3

🎯 Risk Factors

  • 4 files changed (≤5 → LOW)
  • 3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

docs (2 files)
  • docs/src/content/docs/features/ralph.md
  • docs/src/content/docs/reference/cli.md
root (1 file)
  • .changeset/watch-message-warning.md
squad-cli (1 file)
  • packages/squad-cli/src/cli-entry.ts

This report is generated automatically for every PR. See #733 for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the squad watch / squad triage UX by warning when users pass extra positional arguments (which are not used by watch mode), and updates docs/changelog to clarify that watch is a polling loop rather than a message router.

Changes:

  • Always warn (not just in --verbose) when squad watch/triage receives unused positional args.
  • Document the behavior in the CLI reference and Ralph/watch docs.
  • Add changelog + changeset entries for the CLI change.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/squad-cli/src/cli-entry.ts Warns when positional args are provided to watch/triage instead of silently ignoring them.
docs/src/content/docs/reference/cli.md Adds a note in the CLI commands table clarifying extra args are ignored.
docs/src/content/docs/features/ralph.md Adds a cautionary callout explaining watch mode doesn’t route agent messages.
CHANGELOG.md Adds an Unreleased changelog entry describing the new warning + doc clarification.
.changeset/watch-message-warning.md Adds a patch changeset for @bradygaster/squad-cli.

Comment thread CHANGELOG.md Resolved
Comment thread docs/src/content/docs/features/ralph.md Resolved
Comment thread docs/src/content/docs/reference/cli.md Resolved
@diberry
diberry force-pushed the squad/704-watch-message-warning branch from b3d8531 to 8212d04 Compare April 5, 2026 18:06
Detects extra positional args passed to squad watch and prints a clear
warning instead of silently ignoring them. Users who expect routing get
guidance to use an interactive session.

Closes #703

Co-authored-by: tamirdresher <tamirdresher@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry
diberry force-pushed the squad/704-watch-message-warning branch from 8212d04 to 85dc7c8 Compare April 5, 2026 19:02
@diberry

diberry commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing — superseded by #859 which covers the same cli-entry.ts changes comprehensively.

@diberry diberry closed this Apr 6, 2026
@bradygaster
bradygaster deleted the squad/704-watch-message-warning branch August 8, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): squad watch silently ignores quoted message

2 participants