Skip to content

fix(ci): skip Playwright tests in insider publish (covered by Squad CI) #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tamirdresher wants to merge 2 commits into from
Closed

fix(ci): skip Playwright tests in insider publish (covered by Squad CI) #852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f53c2
fix: insider publish workflow — add build step and use Node 22
invalid-email-address Apr 5, 2026
8fc3104
fix(ci): skip Playwright tests in insider publish (covered by Squad CI)
invalid-email-address Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/squad-insider-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
Comment on lines 15 to +17

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the change is swapping the test command, but this workflow also bumps the Node version from 20 to 22 for multiple jobs. Please update the PR description to mention the Node upgrade (or split it into a separate PR) so reviewers understand the full CI surface-area change.

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4

Expand All @@ -33,16 +33,19 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

- uses: ./.github/actions/setup-squad-node
with:
node-version: ${{ matrix.node-version }}

- name: Run tests
run: npm test
- name: Build
run: npm run build

Comment on lines +44 to +46

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test job now runs npm run build even though there is already a separate build job and no artifacts are being passed between jobs. Since each job runs on a fresh runner, this means the project is built twice with no shared output. Consider either removing the standalone build job, or removing this duplicate build step (or uploading build artifacts from the build job and downloading them here if tests truly need the built output).

Suggested change
- name: Build
run: npm run build

Copilot uses AI. Check for mistakes.
- name: Run tests (skip Playwright — covered by Squad CI)
run: npx vitest run --exclude 'test/aspire-integration.test.ts'

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs tests via npx vitest ..., which bypasses the repo’s npm test script (package.json defines test as vitest run). Using npm test (passing the exclude via --) keeps CI aligned with the standard entrypoint and avoids any behavioral differences from npx resolution.

Suggested change
run: npx vitest run --exclude 'test/aspire-integration.test.ts'
run: npm test -- --exclude 'test/aspire-integration.test.ts'

Copilot uses AI. Check for mistakes.

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the Docker/Playwright integration via a hardcoded --exclude test/aspire-integration.test.ts is brittle (a rename/move could accidentally re-enable it in the publish workflow). Since the test already supports SKIP_DOCKER_TESTS=1, consider setting that env var for this step so the workflow intent stays stable even if the file path changes.

Suggested change
run: npx vitest run --exclude 'test/aspire-integration.test.ts'
env:
SKIP_DOCKER_TESTS: '1'
run: npx vitest run

Copilot uses AI. Check for mistakes.

# CI Hardening: npm registry health check (item 10)
# Fail early if registry is unreachable instead of failing mid-publish.
Expand Down Expand Up @@ -81,7 +84,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

Expand Down
Loading