Skip to content

fix: insider publish workflow - add build step and use Node 22 #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tamirdresher wants to merge 1 commit into from
Closed

fix: insider publish workflow - add build step and use Node 22 #851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/squad-insider-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

Expand All @@ -33,14 +33,17 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

- uses: ./.github/actions/setup-squad-node
with:
node-version: ${{ matrix.node-version }}

- name: Build
run: npm run build

Comment on lines +44 to +46

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test job now runs npm run build, but the separate build job already builds and does not publish artifacts. Since GitHub Actions jobs run on separate runners, this results in two independent builds with no reuse. Consider either (a) removing the standalone build job and dropping needs: build, or (b) uploading build outputs from build and downloading them in test to avoid redundant work.

Copilot uses AI. Check for mistakes.
- name: Run tests
run: npm test

Expand Down Expand Up @@ -81,7 +84,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

Expand Down
Loading