fix(cli): squad doctor — add casting dir to upgrade, improve global install warnings by diberry · Pull Request #823 · github/squad

diberry · 2026-04-04T18:15:56Z

Fixes 3 issues found during v0.9.1 insiders testing:

Bug: \squad upgrade\ doesn't create .squad/casting/\ directory — added to ENSURE_DIRECTORIES and scaffold defaults
UX: Doctor warns about missing vscode-jsonrpc and copilot-sdk in global installs — clarified messaging
Investigated: \squad version\ command routing — confirmed correct, may be shell-specific

Related Issues

Closes fix(cli): add .squad/casting to ENSURE_DIRECTORIES in upgrade.ts #820 — Add .squad/casting to ENSURE_DIRECTORIES
Closes fix(cli): doctor ESM checks should clarify global install context #821 — Doctor ESM checks clarify global install context
Relates to test(cli): add init→upgrade→doctor parity test suite #822 — Init→upgrade→doctor parity test suite (deeper prevention work)

Related PRDs

feat: Init/Upgrade Parity & SDK Compatibility Testing — PRD #817 — Init/Upgrade Parity & SDK Compatibility Testing PRD
feat: @github/copilot-sdk Compatibility Testing & Breaking Change Detection — PRD #818 — @github/copilot-sdk Compatibility Testing & Breaking Change Detection PRD
feat(ci): automated bug retro checklist on issue close #819 — Automated Bug Retro Checklist on Issue Close PRD

Root Cause

\squad init\ and \squad upgrade\ are two code paths that should produce the same scaffolding but are maintained independently with no shared contract. When casting was added to init (Mar 23), the upgrade path was never updated. See retro analysis in #817.

Found by Brady during insiders install.

github-actions · 2026-04-04T18:16:12Z

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit b71e8a3

⚠️ 3 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	Changeset file found
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	6 active Copilot thread(s) resolved (4 outdated skipped)
❌	CI passing	15 check(s) still running

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

github-actions · 2026-04-04T18:16:13Z

🏗️ Architectural Review

⚠️ Architectural review: 1 warning(s).

Severity	Category	Finding	Files
🟡 warning	bootstrap-area	1 file(s) in the bootstrap area (packages/squad-cli/src/cli/core/) were modified. These files must maintain zero external dependencies. Review carefully.	`packages/squad-cli/src/cli/core/upgrade.ts`

Automated architectural review — informational only.

Copilot

Pull request overview

This PR addresses insiders-testing issues around upgrade scaffolding and doctor output, ensuring older repos get the newer casting directory/files and making global-install diagnostics less noisy.

Changes:

Add .squad/casting/ to the upgrade directory ensure list and scaffold default casting state files during squad upgrade.
Downgrade certain “missing node_modules dependency” doctor results from warn to info with updated messaging and reporting.
Add inline documentation in the CLI entrypoint about version routing investigation results.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`packages/squad-cli/src/cli/core/upgrade.ts`	Ensures `.squad/casting/` exists and scaffolds default casting JSON files during upgrade.
`test/cli/upgrade.test.ts`	Adds coverage for casting directory creation, default scaffolding, non-overwrite behavior, and upgrade behavior for older repos.
`packages/squad-cli/src/cli/commands/doctor.ts`	Adds `info` status to doctor checks and updates output summary/icon mapping and messaging.
`test/cli/doctor.test.ts`	Updates expectations to match `info` severity and revised messaging for global installs.
`packages/squad-cli/src/cli-entry.ts`	Adds comments clarifying the investigation into `version` command routing reports.

github-actions · 2026-04-04T18:33:23Z

🟡 Impact Analysis — PR #823

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	6
Files added	1
Files modified	5
Files deleted	0
Modules touched	3

🎯 Risk Factors

6 files changed (6-20 → MEDIUM)
3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (1 file)

.changeset/fix-doctor-casting-upgrade.md

squad-cli (3 files)

packages/squad-cli/src/cli-entry.ts
packages/squad-cli/src/cli/commands/doctor.ts
packages/squad-cli/src/cli/core/upgrade.ts

tests (2 files)

test/cli/doctor.test.ts
test/cli/upgrade.test.ts

This report is generated automatically for every PR. See #733 for details.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

…stalls - ensureCastingDefaults() accepts optional templatesDir param to avoid redundant getTemplatesDir() call when invoked from runEnsureChecks() - checkVscodeJsonrpcExports() distinguishes local dev (node_modules present → warn with remediation) from global install (→ info) - checkCopilotSdkSessionPatch() applies the same global vs local logic Resolves 3 unresolved Copilot review comments on PR #823. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

bradygaster

Other than addressing Copilot's reviews, LGTM

bradygaster · 2026-04-04T19:42:51Z

thank you @diberry!

Verifies init and upgrade produce equivalent scaffolding. Tests ENSURE_DIRECTORIES coverage, casting defaults, and .gitattributes. Closes #822 Related: #817, #823 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Verifies init and upgrade produce equivalent scaffolding. Tests ENSURE_DIRECTORIES coverage, casting defaults, and .gitattributes. Closes #822 Related: #817, #823 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Tamir Dresher <tamir.dresher@gmail.com>

FR-2: Extended parity test suite with parametric ENSURE_DIRECTORIES tests, casting/sessions recreation, pre-casting repo simulation, and doctor validation. FR-3: Added upgrade-doctor-check CI job triggered on init/upgrade/doctor changes. FR-7: Centralized global install detection in doctor, improved ESM check messaging. FR-1 (casting fix) already merged via PR #823. FR-4/5/6 (SDK compat) handled in #818. Closes #817 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 4, 2026 18:16

Copilot started reviewing on behalf of diberry April 4, 2026 18:16

View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread packages/squad-cli/src/cli/core/upgrade.ts Resolved

Comment thread packages/squad-cli/src/cli/core/upgrade.ts Resolved

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

diberry force-pushed the fix/squad-doctor-issues branch 2 times, most recently from 27841e1 to 1ab1e74 Compare April 4, 2026 18:38

diberry mentioned this pull request Apr 4, 2026

pr-comment-review skill: GitHub thread resolution gap diberry/squad#134

Open

diberry requested a review from Copilot April 4, 2026 18:50

Copilot started reviewing on behalf of diberry April 4, 2026 18:50

View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread packages/squad-cli/src/cli/core/upgrade.ts Resolved

Comment thread packages/squad-cli/src/cli/core/upgrade.ts Resolved

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

diberry force-pushed the fix/squad-doctor-issues branch from f008ad7 to 5aed14e Compare April 4, 2026 19:07

diberry requested a review from Copilot April 4, 2026 19:08

Copilot started reviewing on behalf of diberry April 4, 2026 19:09

View session

diberry requested review from bradygaster and tamirdresher April 4, 2026 19:12

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

diberry requested a review from Copilot April 4, 2026 19:25

Copilot started reviewing on behalf of diberry April 4, 2026 19:26

View session

Copilot AI reviewed Apr 4, 2026

View reviewed changes

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

Comment thread packages/squad-cli/src/cli/commands/doctor.ts Resolved

bradygaster reviewed Apr 4, 2026

View reviewed changes

Comment thread packages/squad-cli/src/cli/core/upgrade.ts Resolved

Merge branch 'dev' into fix/squad-doctor-issues

b71e8a3

diberry merged commit 2f807d6 into dev Apr 4, 2026
17 checks passed

diberry deleted the fix/squad-doctor-issues branch April 4, 2026 21:04

diberry mentioned this pull request Apr 4, 2026

test(cli): add init→upgrade→doctor parity test suite #840

Merged

diberry mentioned this pull request Apr 8, 2026

feat(cli): init/upgrade parity tests, CI gate, doctor global install UX [ON HOLD] #912

Closed

Conversation

diberry commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

Related PRDs

Root Cause

Uh oh!

github-actions Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛫 PR Readiness Check

⚠️ 3 item(s) to address before review

Uh oh!

github-actions Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏗️ Architectural Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Impact Analysis — PR #823

📊 Summary

🎯 Risk Factors

📦 Modules Affected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

bradygaster left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bradygaster commented Apr 4, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

diberry commented Apr 4, 2026 •

edited

Loading

github-actions Bot commented Apr 4, 2026 •

edited

Loading

github-actions Bot commented Apr 4, 2026 •

edited

Loading

github-actions Bot commented Apr 4, 2026 •

edited

Loading