Repository navigation
feat(watch): --verbose flag for debugging empty boards #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7d91556
feat(watch): add --verbose flag for debugging empty boards and silent…
invalid-email-address 1f8e601
fix: address Copilot review comments on --verbose PR (#782)
invalid-email-address b6d38f8
Merge branch 'dev' into squad/781-watch-verbose
tamirdresher e356645
fix: address Copilot review comments
invalid-email-address e6247b9
merge: resolve conflicts between verbose-flag and watch-ux-fixes from…
tamirdresher e894553
merge: resolve conflicts with dev (fleet-dispatch + ux-fixes)
tamirdresher 820b148
fix: remove undefined maxConcurrent ref in execute.ts verbose log
tamirdresher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@bradygaster/squad-cli": minor | ||
| --- | ||
|
|
||
| Add --verbose flag to squad watch for debugging empty boards and silent failures (#781) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /** | ||
| * Verbose logger for squad watch debugging. | ||
| * Only outputs when --verbose is enabled. | ||
| */ | ||
| export function createVerboseLogger(enabled: boolean) { | ||
| return { | ||
| log: (...args: unknown[]) => { | ||
| if (enabled) console.log('[verbose]', ...args); | ||
| }, | ||
| warn: (...args: unknown[]) => { | ||
| if (enabled) console.log('[verbose] ⚠️', ...args); | ||
| }, | ||
| section: (title: string) => { | ||
| if (enabled) console.log(`[verbose] ── ${title} ──`); | ||
| }, | ||
| table: (data: Record<string, unknown>) => { | ||
| if (enabled) { | ||
| for (const [k, v] of Object.entries(data)) { | ||
| console.log(`[verbose] ${k}: ${v}`); | ||
| } | ||
| } | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| export type VerboseLogger = ReturnType<typeof createVerboseLogger>; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The startup verbose table hard-codes
verbose: true, which can be misleading if the logger enablement logic changes (and is redundant since the table only prints when verbose is enabled). Prefer usingconfig.verbose(or omitting this field entirely) so the diagnostic output reflects the actual configuration source-of-truth.