[diberry]

Closes #748

Implements the registry query layer PRD (docs/proposals/registry-query-layer.md).
Shared foundation that both #670 (layout manifest) and #733 (impact analysis) consume.

What's in this PR

• *\scripts/registry-query.mjs* — 5 exported functions:

  • \loadRegistry()\ — load and parse repo-registry.json
  • 
    esolveFile()\ — single file → module/owner/package/tier resolution (longest-prefix match)
  • \�nalyzeFiles()\ — batch analysis producing AnalysisResult with aggregates
  • \computeRiskTier()\ — risk tier computation (LOW/MEDIUM/HIGH/CRITICAL)
  • \getInvolvedOwners()\ — deduplicated, ranked owner list

• *\ est/registry-query.test.ts* — 33 test cases covering all acceptance criteria

• Changeset for patch release

Dependencies

Depends on: PR #737 (repo registry data — includes
egistry-utils.mjs\ and
epo-registry.json\ as prereqs)
Feeds into: #670, #733

Working as EECOM (Core Dev)

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[Copilot]

Pull request overview

Implements a shared “registry query layer” over .squad/repo-registry.json to support consistent file→module/owner/package resolution, batch analysis, risk scoring, and owner aggregation for downstream tooling (layout manifest + impact analysis).

Changes:

• Added scripts/registry-query.mjs with functions for registry loading, file resolution, batch analysis, risk tier computation, and owner aggregation.
• Added test/registry-query.test.ts with a comprehensive Vitest suite covering resolution, aggregation, and risk tier behavior.
• Added/updated registry data + metadata (.squad/repo-registry.json) and project bookkeeping (decision/history entries + changeset).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
scripts/registry-query.mjs	Core query + analysis API over repo registry (resolve/analyze/risk/owners).
test/registry-query.test.ts	Validates file resolution, aggregates, risk tier thresholds, and owner ranking.
scripts/registry-utils.mjs	Low-level registry utilities (includes some encoding issues in comments).
.squad/repo-registry.json	Committed registry dataset + metadata used by tests and scripts.
.squad/decisions/inbox/eecom-registry-query-impl.md	Records implementation decision (date currently in the future).
.squad/agents/eecom/history.md	Captures implementation learnings (date currently in the future).
.changeset/registry-query-layer.md	Declares a patch release for @bradygaster/squad-cli.

[Copilot]

The header comment says this module “builds on top of registry-utils.mjs”, but registry-query.mjs re-implements module resolution internally and never imports registry-utils. Update the docstring to reflect the actual dependency model (pure functions over passed-in registry) to avoid misleading future consumers.

Suggested change

	* Builds on top of registry-utils.mjs (PR #737) to provide batch file analysis,
	* risk tier computation, and owner aggregation. Shared foundation consumed by
	* #670 (layout manifest) and #733 (PR impact analysis).
	* Provides pure functions over a passed-in registry object to perform batch
	* file analysis, risk tier computation, and owner aggregation. Includes a
	* small convenience helper to load the registry JSON from disk. Shared
	* foundation consumed by #670 (layout manifest) and #733 (PR impact analysis).

[Copilot]

PR description references a PRD at docs/proposals/registry-query-layer.md, but that file isn’t present in the repo (no matches). Either add the PRD document at that path or update references to the correct location so reviewers/consumers can validate acceptance criteria.

[Copilot]

analyzeFiles() only adds primaryOwner to ownersTouched; secondary owners are omitted from the summary even when they’re involved via moduleDetails. If ownersTouched is intended to represent all involved owners, include secondaryOwner in the aggregation (and consider whether template/critical non-module owners should be represented too).

Suggested change

	if (f.primaryOwner) ownersSet.add(f.primaryOwner);
	if (f.primaryOwner) ownersSet.add(f.primaryOwner);
	if (f.secondaryOwner) ownersSet.add(f.secondaryOwner);

[Copilot]

boundariesCrossed is described as a cross-package concept, but the current calculation (modulesTouched.length - 1 when >1 package) will overcount whenever multiple modules exist within the same package (e.g., 10 modules across 2 packages yields 9). Consider computing this as packagesTouched.length - 1, or explicitly count modules whose package differs from the first package, depending on the intended definition.

Suggested change

	// Boundary crossing: modules spanning >1 package
	const boundariesCrossed =
	packagesTouched.length > 1 ? modulesTouched.length - 1 : 0;
	// Boundary crossing: cross-package span (number of additional packages beyond the first)
	const boundariesCrossed =
	packagesTouched.length > 1 ? packagesTouched.length - 1 : 0;

[Copilot]

The comment contains mojibake (“ΓåÆ”), which suggests an encoding issue. Replace it with the intended symbol/text (e.g., “→”) to keep the file ASCII/UTF-8 clean and readable.

Suggested change

	// Determine package from file path prefix (e.g. packages/squad-sdk/ → squad-sdk)
	// Determine package from file path prefix (e.g. packages/squad-sdk/ → squad-sdk)

[Copilot]

The registry metadata claims it was generated by scripts/generate-repo-registry.mjs, but that script isn’t present in the repository. Either add the generator at that path or update the metadata to the actual generator script so the registry can be regenerated reliably.

Suggested change

	"generator": "scripts/generate-repo-registry.mjs",
	"generator": ".squad/scripts/generate-repo-registry.mjs",

[Copilot]

This string includes mojibake (“ΓÇö”), which suggests an encoding issue in the generator output. Replace it with the intended em dash (—) (and ensure the generator writes UTF-8) so the committed JSON is clean and searchable.

Suggested change

	"description": "Unmapped path ΓÇö update routing.md"
	"description": "Unmapped path — update routing.md"

[Copilot]

This changeset targets @bradygaster/squad-cli, but the PR changes are in repo-root scripts and .squad data, and there are no references/usages of registry-query under packages/. If this isn’t a published package change, consider removing the changeset or targeting the correct package/release mechanism.

Suggested change

	---
	"@bradygaster/squad-cli": patch
	---
	feat: registry query layer — shared foundation for layout manifest and impact analysis (#748)