Skip to content

fix(ci): add build step to insider publish test job #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tamirdresher wants to merge 1 commit into from
Closed

fix(ci): add build step to insider publish test job #722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/squad-insider-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

Expand All @@ -33,14 +33,17 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

- uses: ./.github/actions/setup-squad-node
with:
node-version: ${{ matrix.node-version }}

- name: Build (required for subpath export resolution)
run: npm run build

Comment on lines +44 to +46

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new build step makes the workflow run npm run build in both the build job (line 27) and again in the test job, which doubles build time without sharing artifacts. Consider either removing the standalone build job/needs: build, or uploading build artifacts in build and downloading them in test instead of rebuilding.

Copilot uses AI. Check for mistakes.
Comment on lines +44 to +46

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the test job now builds, it’s more important that the Node version here matches the repo’s supported engines. package.json specifies engines.node >=22.5.0, but this workflow matrix uses Node 20; consider bumping this workflow to a supported Node version (or adjusting engines if 20 is intended to be supported).

Copilot uses AI. Check for mistakes.
- name: Run tests
run: npm test

Expand Down Expand Up @@ -81,7 +84,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
node-version: [20]
node-version: [22]
steps:
- uses: actions/checkout@v4

Expand Down
Loading