Repository navigation
Conversation
…oversized file When decisions.md exceeds 20KB but archiveDecisions() returns null (no entries archivable — all recent or undated), emit a warning action in the nap report instead of silently reporting 'nothing to clean up'. Changes from review: - Add 'warning' type to NapAction (was using 'cleanup' with cast) - Extract oversizedDecisionsWarning() helper (DRY — was duplicated in runNap/runNapSync) - Tests assert on type='warning' instead of just description text Closes #25 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@bradygaster Ready for your review — team-approved with 3-reviewer gate (Flight, FIDO, Procedures). |
Contributor
Author
|
Closing as duplicate — Brady merged related archival fallback in #627 (count-based archiveDecisions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decisions.md exceeds 20KB but archiveDecisions() returns null (no entries archivable), emit a warning action. Adds 'warning' type to NapAction, extracts oversizedDecisionsWarning() helper. 3 tests.
Team review: Flight ✅, FIDO ✅, Procedures ✅
Closes diberry#25