Skip to content

fix: P0 upgrade path gaps (#544) - #545

Merged
bradygaster merged 1 commit into
devfrom
squad/544-upgrade-path-fixes
Mar 23, 2026
Merged

bradygaster merged 1 commit into
devfrom
squad/544-upgrade-path-fixes

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

Closes #544

Working as EECOM (Core Dev)

What changed

Fixes 10 gaps in \squad upgrade\ identified by 3-agent audit:

  1. ensureGitattributes — appends \merge=union\ rules if missing (idempotent)
  2. ensureGitignore — appends required ignore entries if missing (idempotent)
  3. ensureDirectories — creates .squad/identity, .squad/sessions, .copilot/skills, etc.
  4. Refresh .squad/templates/ — copies latest package templates on every upgrade
  5. Sync all skills — copies all skills to .copilot/skills/\ (force: false, won't overwrite user edits)
  6. issue-lifecycle.md added to TEMPLATE_MANIFEST — the only missing file that actually exists in templates/
  7. 'already current' path runs ensure checks — \squad upgrade\ always repairs infrastructure
  8. --force\ flag — bypasses version check, forces full manifest processing
  9. issue-lifecycle.md copied to .squad-templates/ — canonical source complete
  10. 10 new tests — ensureGitattributes, ensureGitignore, ensureDirectories, idempotency, already-current path, --force flag

All 18 upgrade tests pass.

…plates (#544)

- Add ensureGitattributes() to repair merge=union rules on upgrade
- Add ensureGitignore() to repair required ignore entries on upgrade
- Add ensureDirectories() to create missing infrastructure dirs
- Sync all skills from templates to .copilot/skills/ (force: false)
- Refresh .squad/templates/ with latest package templates
- Add issue-lifecycle.md to TEMPLATE_MANIFEST
- Make 'already current' path run all ensure* checks
- Add --force flag to bypass version check
- Copy issue-lifecycle.md to .squad-templates/ canonical source
- Add 10 new tests covering ensure functions, idempotency, force flag

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster merged commit 6469a59 into dev Mar 23, 2026
0 of 2 checks passed
chrislomonico pushed a commit to clomonico/squad that referenced this pull request Mar 26, 2026
github#545)

Adds opt-in OTel shell metrics (SQUAD_TELEMETRY=1): session_count, session_duration_ms, agent_response_latency_ms, error_count. Zero overhead when off.

Closes github#508, Closes github#520, Closes github#526, Closes github#530, Closes github#531

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster deleted the squad/544-upgrade-path-fixes branch March 26, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0: squad upgrade misses .gitattributes, .gitignore, skills, templates, and directories for existing users

1 participant