Skip to content

test: repo-health post-merge canary - #2422

Closed
tamirdresher wants to merge 2 commits into
devfrom
canary/repo-health-1794165208
Closed

tamirdresher wants to merge 2 commits into
devfrom
canary/repo-health-1794165208

Conversation

@tamirdresher

Copy link
Copy Markdown
Collaborator

What

Disposable, authoritative post-merge canary for the repo-health workflow split merged in #2409. Do not merge. It adds one .squad/ file whose name contains paired backticks, a bare ${, an apostrophe, and a double quote. A second push deletes the file to prove stale-comment cleanup. The PR is then closed and its branch deleted.

Why

.github/REPO_HEALTH_RUNBOOK.md ("Authoritative post-merge canary") makes this run the only authoritative evidence for a repo-health workflow or reporter change. #2409 moved Repo Health to pull_request and its comment writer, Repo Health Report, to workflow_run. Relates to #2407 and #2409.

How

The commit is built through the GitHub Git Data API because the hostile filename can't be created on Windows. Verification follows the runbook:

  1. After the first push, there is exactly one <!-- squad-repo-health-leakage --> comment. It lists only the exact path, is labeled Authoritative evidence, and names the canary head commit.
  2. After the delete push, no leakage marker comment remains.

The PR URL and the Repo Health and Repo Health Report run URLs for both pushes will be recorded on #2409.


⚠️ Quick Check

  • If SDK/CLI source files changed: completed the applicable Changeset step below (npx changeset add / .changeset/*.md, direct CHANGELOG.md entry for maintainers, or skip-changelog label for no user-facing changes): N/A, no SDK/CLI source files change.

PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

  • Branch created from dev (not main)
  • Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
  • Verified diff contains only intended changes (git diff --cached --stat): one .squad/ canary file.
  • PR is not in draft mode (mark ready when checks pass): stays a draft by design, so no review is requested; it is never merged.
  • Commit history is clean (squash fixups before review)

Build & Test

  • npm run build passes: not run locally, because the PR changes no code. Squad CI runs on the PR.
  • npm test passes (all tests green): not run locally, same reason.
  • npm run lint passes (type check clean): not run locally, same reason.
  • npm run lint:eslint passes: not run locally, same reason.
  • For migration PRs (>20 files): include test output summary in PR description: N/A, one file.

Changeset

  • Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed): N/A, neither path changes.
  • Or direct CHANGELOG.md entry (maintainers only — write-protected for external contributors): N/A.
  • Or skip-changelog label applied (if no user-facing changes): N/A, live .squad/ state is outside the changelog gate.

Docs

  • README section updated (if new feature/module): N/A, no user-facing change.
  • Docs feature page (if new user-facing capability): N/A, no user-facing change.

Exports

  • package.json subpath exports updated (if new module): N/A, no SDK change.

Breaking Changes

None.

Waivers

None. This PR is closed without merging.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Impact Analysis — PR #2422

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 0
Files added 0
Files modified 0
Files deleted 0
Modules touched 0

🎯 Risk Factors

  • 0 files changed (≤5 → LOW)
  • 0 module(s) touched (≤1 → LOW)

📦 Modules Affected


This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 76ed145

PR Scope: 🔧 Infrastructure

⚠️ 4 item(s) to address before review

Status Check Details
❌ Single commit 2 commits — consider squashing before review
❌ Not in draft PR is still in draft — mark as ready for review when done
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 2 check(s) failing: test, upgrade-matrix (windows-latest)

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tamirdresher

Copy link
Copy Markdown
Collaborator Author

Canary complete. Both phases passed per .github/REPO_HEALTH_RUNBOOK.md: one authoritative leakage marker with the exact hostile path for head 1dfbdaf, and no marker after the delete push (76ed145). Evidence is recorded on #2409. Closing without merging.

@tamirdresher
tamirdresher deleted the canary/repo-health-1794165208 branch November 8, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant