Repository navigation
fix(sdk): share memory locks across backend worktrees - #2383
Merged
bradygaster merged 1 commit intoNov 4, 2026
Merged
Conversation
Use the configured state ref for memory index locks so parallel checkouts cannot overwrite each other's updates. Closes github#2379 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🟡 Impact Analysis — PR #2383Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
squad-sdk (2 files)
tests (2 files)
|
Contributor
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (5 files, +55 −10)
| File | +/− |
|---|---|
.changeset/quiet-locks-follow-state.md |
+5 −0 |
packages/squad-sdk/src/memory/index.ts |
+18 −9 |
packages/squad-sdk/src/state-backend.ts |
+6 −0 |
test/backend.test.ts |
+6 −1 |
test/state-backend.test.ts |
+20 −0 |
Total: +55 −10
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
omercangumus
marked this pull request as ready for review
November 1, 2026 19:30
omercangumus
requested review from
bradygaster and
tamirdresher
as code owners
November 1, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Route memory index locks through the configured state backend so worktrees sharing an orphan or two-layer ref contend on the same machine-local lock.\n- Keep the existing resolved .squad lock behavior for filesystem storage.\n- Add coverage for adapter-backed memory writes and linked-worktree lock identity.\n\nCloses #2379