Repository navigation
fix(sdk): prevent concurrent memory index loss - #2356
Merged
tamirdresher merged 2 commits intoNov 1, 2026
Merged
Conversation
Contributor
🟠 Impact Analysis — PR #2356Risk tier: 🟠 HIGH 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
root (1 file)
scripts (1 file)
squad-sdk (3 files)
tests (3 files)
|
Contributor
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 16 check(s) still running |
Files Changed (9 files, +192 −47)
| File | +/− |
|---|---|
.changeset/calm-index-lock.md |
+5 −0 |
.github/workflows/squad-release-verify.yml |
+1 −1 |
packages/squad-sdk/src/backend/local-backend.ts |
+2 −1 |
packages/squad-sdk/src/memory/index.ts |
+50 −26 |
packages/squad-sdk/src/storage/fs-storage-provider.ts |
+9 −1 |
scripts/release/test-reconciliation.mjs |
+7 −0 |
test/cli-packaging-smoke.test.ts |
+1 −1 |
test/memory-providers.test.ts |
+71 −0 |
test/test-reconciliation.test.ts |
+46 −17 |
Total: +192 −47
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
omercangumus
force-pushed
the
omercangumus/2334-memory-index-lock
branch
3 times, most recently
from
October 28, 2026 15:10
42c721f to
f03a0f8
Compare
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
omercangumus
marked this pull request as ready for review
October 28, 2026 15:24
omercangumus
requested review from
bradygaster and
tamirdresher
as code owners
October 28, 2026 15:24
omercangumus
force-pushed
the
omercangumus/2334-memory-index-lock
branch
2 times, most recently
from
October 28, 2026 15:43
83176c2 to
410fdd1
Compare
omercangumus
marked this pull request as draft
October 28, 2026 15:43
omercangumus
marked this pull request as ready for review
October 28, 2026 15:52
Serialize governed-memory index updates with shared .squad locks and unique temp files. Initialize indexes atomically and retry transient Windows rename failures. Give the package smoke test setup enough time on slower CI runners. Closes github#2334. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
omercangumus
force-pushed
the
omercangumus/2334-memory-index-lock
branch
from
October 31, 2026 22:34
410fdd1 to
aec64db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2334\n\nSerializes memory index updates with a local .squad lock, writes each update through a unique temp file, and retries transient Windows rename failures. Index creation is atomic too.\n\nChecks: SDK and CLI builds, npm run lint, memory-provider tests (38 passed), backend lock tests (17 passed). The full Windows test suite hit unrelated environment-dependent failures, including missing jq, and did not complete cleanly.