Repository navigation
Detect broken history archives in doctor - #2325
tamirdresher merged 2 commits into
Conversation
🟡 Impact Analysis — PR #2325Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
squad-cli (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 📦🔧 Mixed (product + infrastructure)
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 15 check(s) still running |
Files Changed (3 files, +307 −1)
| File | +/− |
|---|---|
.changeset/archive-pointers-are-validated.md |
+5 −0 |
packages/squad-cli/src/cli/commands/doctor.ts |
+197 −1 |
test/cli/doctor.test.ts |
+105 −0 |
Total: +307 −1
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
|
Thanks Omer! The pointer scan and tracked file check for #1836 look good, and I verified it merges cleanly with dev. Two adjustments we need before merging after the 2.0.0-preview.2 freeze:
|
|
Thanks for catching both issues. A tracked archive changed by squad nap should not be a hard failure, and the integrity check should not run Git tracking checks against two-layer, orphan, or externalized state. I will make those adjustments and push an update. |
Fixes github#1836 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eaa56b8 to
9dea3a8
Compare
|
Thanks again for the catches. I pushed an update: tracked archive changes now warn instead of fail, and the Git checks are skipped for orphan/two-layer backends and state outside the worktree. I added regression coverage for those cases; CI is running now. |
What changed
Closes #1836