Repository navigation
fix(test): don't count packaging timeouts as passes - #2289
Merged
tamirdresher merged 5 commits intoOct 24, 2026
Merged
tamirdresher merged 5 commits into
tamirdresher merged 5 commits into
Conversation
Closes github#1795 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 5 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 13 check(s) still running |
Files Changed (1 file, +23 −12)
| File | +/− |
|---|---|
test/cli-packaging-smoke.test.ts |
+23 −12 |
Total: +23 −12
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟢 Impact Analysis — PR #2289Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedtests (1 file)
This report is generated automatically for every PR. See #733 for details. |
omercangumus
marked this pull request as ready for review
October 23, 2026 20:09
omercangumus
requested review from
bradygaster and
tamirdresher
as code owners
October 23, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A timeout in the packaging smoke test no longer looks like a clean exit. Routing checks still accept a timeout when they mean to.
Why
A hung command could satisfy
exitCode === 0, so the packaging check could pass for the wrong reason. Closes #1795.How
exitCode: nullalongsidetimedOut: true.--versionand--helpa longer cold-start window on Windows.Checks
npm run buildandnpm run lintpassed.--hookTimeout 60000for Windows cleanup.Only a test file changed, so no changeset is needed.