Skip to content

fix(test): don't count packaging timeouts as passes - #2289

Merged
tamirdresher merged 5 commits into
github:devfrom
omercangumus:omercangumus/1795-packaging-timeout-signal
Oct 24, 2026
Merged

tamirdresher merged 5 commits into
github:devfrom
omercangumus:omercangumus/1795-packaging-timeout-signal

Conversation

@omercangumus

Copy link
Copy Markdown
Contributor

What

A timeout in the packaging smoke test no longer looks like a clean exit. Routing checks still accept a timeout when they mean to.

Why

A hung command could satisfy exitCode === 0, so the packaging check could pass for the wrong reason. Closes #1795.

How

  • Return exitCode: null alongside timedOut: true.
  • Test a deliberately hanging Node process and confirm it cannot report success.
  • Give --version and --help a longer cold-start window on Windows.

Checks

  • npm run build and npm run lint passed.
  • Packaging smoke test: 32/32 passed with --hookTimeout 60000 for Windows cleanup.
  • ESLint on the changed file: 0 errors, 2 existing console warnings.
  • The full local suite hit unrelated Windows failures in gh-aw and first-run tests; I stopped it after those failures. I am not counting it as passed.

Only a test file changed, so no changeset is needed.

Closes github#1795

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 24e74fa

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status Check Details
❌ Single commit 5 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 13 check(s) still running

Files Changed (1 file, +23 −12)

File +/−
test/cli-packaging-smoke.test.ts +23 −12

Total: +23 −12


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Impact Analysis — PR #2289

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 1
Files added 0
Files modified 1
Files deleted 0
Modules touched 1

🎯 Risk Factors

  • 1 files changed (≤5 → LOW)
  • 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

tests (1 file)
  • test/cli-packaging-smoke.test.ts

This report is generated automatically for every PR. See #733 for details.

@omercangumus
omercangumus marked this pull request as ready for review October 23, 2026 20:09
@tamirdresher
tamirdresher merged commit 73c4e64 into github:dev Oct 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging smoke harness reports exitCode: 0 for timed-out commands — a hang is indistinguishable from a pass

2 participants