Repository navigation
chore(ci): 30-minute test budget and Playwright browser cache - #2284
Merged
Merged
Conversation
…browsers Two stacked-PR runs were cancelled by the 15-minute job budget before vitest finished: setup alone took 10-12 minutes (one Playwright chromium download ran 10m33s vs 22s on a healthy runner) while the suite itself needs ~6 minutes. Cache ~/.cache/ms-playwright keyed on the Playwright version (cache hit installs only OS deps) and raise the budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b822a455-fa94-49a2-9127-eee479ab954e
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (1 file, +19 −2)
| File | +/− |
|---|---|
.github/workflows/squad-ci.yml |
+19 −2 |
Total: +19 −2
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟢 Impact Analysis — PR #2284Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused workflow changes preserve browser and system-dependency installation on both cache paths, with no blocking issues identified.
No open issues 🎉
What changed in this PR
This workflow-only PR gives Squad CI more time to complete tests when setup is slow and reduces repeated Playwright browser downloads.
Changes:
- Increases the
testjob timeout from 15 to 30 minutes. - Caches Playwright browsers by runner OS and installed Playwright version.
- Preserves system-dependency installation on cache hits and full browser installation on misses.
| File | Description |
|---|---|
.github/workflows/squad-ci.yml |
Extends the test budget and adds version-keyed Playwright browser caching. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give the Squad CI
testjob a 30-minute budget (was 15) and cache Playwright browsers across runs.Why
Two stacked-PR runs (#2278
662fb636, #227952c467cc) were cancelled by the job budget before vitest finished. Step timings from the cancelled attempts: setup took 10–12 min — onenpx playwright install chromium --with-depsran 10m33s (22s on a healthy runner, #2277) — leaving ~2.5 min of the budget for a ~6-minute suite. The suite size did not change; runner/CDN speed did.How
timeout-minutes: 30on thetestjob (comment explains why).actions/cache(same pinned SHA already used inagentics-maintenance.yml) on~/.cache/ms-playwright, keyed onrunner.os+ the installed Playwright version; on a cache hit onlyplaywright install-deps chromiumruns.repo-healthscope:.github/only.skip-changelogPR Readiness Checklist
dev, up to date, single intended changetest/ci/changelog-gate,standalone-release-workflow,ci-concurrencypass locally (gh-aw capacity tests needgh awv0.91 locally — env, identical without this change)Breaking Changes
None.
Waivers
None.