Skip to content

chore(ci): run Squad CI on stacked PRs targeting squad2-*/stack-* branches - #2280

Merged
bradygaster merged 1 commit into
devfrom
squad2-ci-stacked-prs
Oct 22, 2026
Merged

bradygaster merged 1 commit into
devfrom
squad2-ci-stacked-prs

Conversation

@tamirdresher

Copy link
Copy Markdown
Collaborator

What

Add squad2-* and stack-* to pull_request.branches in Squad CI so stacked PRs get the full gates on each layer's own head.

Why

The Squad 2.0 follow-up is a 3-PR stack (#2277 → #2278 → #2279). Only the bottom layer targets dev, so the upper layers currently get no vitest run until GitHub retargets them after a merge. Reviewers asked for CI on every layer's head (Worf LB-4).

How

One line in .github/workflows/squad-ci.yml. The workflow already computes its change set from github.event.pull_request.base.sha, so a stacked base works without further changes. repo-health scope: .github/ only, no product code.


⚠️ Quick Check

  • No SDK/CLI source changed → skip-changelog applies

PR Readiness Checklist

  • Branch created from dev; up to date; diff is the single intended change
  • Not draft; single commit
  • Build/test not affected (workflow trigger only)
  • Changeset: N/A (skip-changelog)
  • Docs: N/A
  • Exports: N/A

Breaking Changes

None.

Waivers

None.

…nches

The workflow already diffs against the PR base SHA, so each layer of a stacked PR gets the
same gates on its own head instead of only after retargeting to dev.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b822a455-fa94-49a2-9127-eee479ab954e
Copilot AI balanced review requested due to automatic review settings October 22, 2026 18:08
@tamirdresher tamirdresher added the skip-changelog Skip changelog enforcement for this PR label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🟢 Impact Analysis — PR #2280

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 1
Files added 0
Files modified 1
Files deleted 0
Modules touched 1

🎯 Risk Factors

  • 1 files changed (≤5 → LOW)
  • 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

ci-workflows (1 file)
  • .github/workflows/squad-ci.yml

This report is generated automatically for every PR. See #733 for details.

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

Authoritative evidence: base-controlled pull_request_target reporter.

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit b179ec9

PR Scope: 🔧 Infrastructure

⚠️ 1 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
✅ CI passing All checks passing

Files Changed (1 file, +2 −1)

File +/−
.github/workflows/squad-ci.yml +2 −1

Total: +2 −1


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped trigger change matches the referenced stack’s branch names and introduces no identified blocking issues.

No open issues 🎉

What changed in this PR

Extends Squad CI to stacked PRs targeting squad2-* and stack-* branches, allowing upper layers of the Squad 2.0 stack to receive CI checks before retargeting to dev.

Changes:

  • Adds both branch patterns while preserving the existing dev and main PR triggers.
  • Adds an explanatory comment; job logic and push triggers remain unchanged.
File Description
.github/​workflows/​squad-ci.yml Expands PR branch filters to include stacked-PR bases.

Review effort: Balanced

@bradygaster
bradygaster merged commit fb15fd5 into dev Oct 22, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip changelog enforcement for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants