Repository navigation
chore(ci): run Squad CI on stacked PRs targeting squad2-*/stack-* branches - #2280
Conversation
…nches The workflow already diffs against the PR base SHA, so each layer of a stacked PR gets the same gates on its own head instead of only after retargeting to dev. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b822a455-fa94-49a2-9127-eee479ab954e
🟢 Impact Analysis — PR #2280Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
🏗️ Architectural Review
Automated architectural review — informational only. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (1 file, +2 −1)
| File | +/− |
|---|---|
.github/workflows/squad-ci.yml |
+2 −1 |
Total: +2 −1
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped trigger change matches the referenced stack’s branch names and introduces no identified blocking issues.
No open issues 🎉
What changed in this PR
Extends Squad CI to stacked PRs targeting squad2-* and stack-* branches, allowing upper layers of the Squad 2.0 stack to receive CI checks before retargeting to dev.
Changes:
- Adds both branch patterns while preserving the existing
devandmainPR triggers. - Adds an explanatory comment; job logic and push triggers remain unchanged.
| File | Description |
|---|---|
.github/workflows/squad-ci.yml |
Expands PR branch filters to include stacked-PR bases. |
Review effort: Balanced
What
Add
squad2-*andstack-*topull_request.branchesin Squad CI so stacked PRs get the full gates on each layer's own head.Why
The Squad 2.0 follow-up is a 3-PR stack (#2277 → #2278 → #2279). Only the bottom layer targets
dev, so the upper layers currently get no vitest run until GitHub retargets them after a merge. Reviewers asked for CI on every layer's head (Worf LB-4).How
One line in
.github/workflows/squad-ci.yml. The workflow already computes its change set fromgithub.event.pull_request.base.sha, so a stacked base works without further changes.repo-healthscope:.github/only, no product code.skip-changelogappliesPR Readiness Checklist
dev; up to date; diff is the single intended changeskip-changelog)Breaking Changes
None.
Waivers
None.